Skip to content

ATLAS-5303: ATLAS React UI: Audit Filters dropdown UI breaks when audit table has no data#694

Merged
pawarprasad123 merged 3 commits into
apache:masterfrom
Brijesh619:ATLAS-5303
Jul 16, 2026
Merged

ATLAS-5303: ATLAS React UI: Audit Filters dropdown UI breaks when audit table has no data#694
pawarprasad123 merged 3 commits into
apache:masterfrom
Brijesh619:ATLAS-5303

Conversation

@Brijesh619

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

ATLAS-5303: ATLAS React UI: Audit Filters dropdown UI breaks when audit table has no data

  • Refactored AdminAuditTable to pass the "Filters" button natively into the TableLayout via the customLeftButton property.
  • Removed the floating div wrapper and negative margins that previously caused the UI layout to break when the table was empty.
  • Disabled the Filters button during table loading to prevent API race conditions.
  • Updated the TableLayout mock in the test suite to properly render customLeftButton.

How was this patch tested?

  • Unit Tests: Updated AdminAuditTable.test.tsx to assert the disabled loading state and verify the mock structure. Verified all 50 tests pass successfully (npm run test).
  • Manual Tests: Verified the Filters button aligns cleanly within the table toolbar when the audit table is fully populated and when it displays "No Records found!".

@Brijesh619

Copy link
Copy Markdown
Contributor Author
Screenshot from 2026-07-10 13-16-57

@Brijesh619

Copy link
Copy Markdown
Contributor Author
Screenshot from 2026-07-10 14-50-43

@pawarprasad123 pawarprasad123 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pawarprasad123 pawarprasad123 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pawarprasad123
pawarprasad123 merged commit 0fd03e3 into apache:master Jul 16, 2026
2 checks passed
pawarprasad123 pushed a commit that referenced this pull request Jul 16, 2026
…it table has no data (#694)

 ( cherry picked form the commit 0fd03e3)

* ATLAS-5303: ATLAS React UI: Audit Filters dropdown UI breaks when audit table has no data

* ATLAS-5303: ATLAS React UI: Audit Filters dropdown UI breaks when audit table has no data

* ATLAS-5303: ATLAS React UI: Audit Filters dropdown UI breaks when audit table has no data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants