Skip to content

ci: enable ASF Copilot code review#833

Open
wgtmac wants to merge 4 commits into
apache:mainfrom
wgtmac:copilot_code_review
Open

ci: enable ASF Copilot code review#833
wgtmac wants to merge 4 commits into
apache:mainfrom
wgtmac:copilot_code_review

Conversation

@wgtmac

@wgtmac wgtmac commented Jul 16, 2026

Copy link
Copy Markdown
Member

Rationale for this change

GitHub Copilot code review may help provide preliminary feedback on pull requests and reduce reviewer load while keeping human maintainers responsible for final review decisions.

What changes are included in this PR?

  • Enable ASF-managed GitHub Copilot code review in .asf.yaml
  • Disable automatic reviews for draft PRs
  • Enable automatic reviews on new pushes
  • Add Copilot review instructions to reduce noisy comments

Are these changes tested?

Yes. .asf.yaml was parsed successfully as YAML, and git diff --check passed.

Are there any user-facing changes?

No.

@kevinjqliu kevinjqliu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!


## Code review

You are a pragmatic senior developer. When reviewing pull requests,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pragmatic senior developer

😄

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is always funny to see the role-playing starting sentence in any prompt :)

@kevinjqliu kevinjqliu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add to the RAT exclude file?
similar to https://github.com/apache/arrow/pull/50117/changes#diff-77b9316eb3849bde766d758cae4e352860a33859469224aaaaf63fd17ceb46efR104

I dont see any entries that would exclude the new file

@wgtmac

wgtmac commented Jul 17, 2026

Copy link
Copy Markdown
Member Author

Added .github/copilot-instructions.md to the RAT exclude file, following the Arrow setup.

Comment thread dev/release/rat_exclude_files.txt Outdated
Comment thread dev/release/rat_exclude_files.txt Outdated
@leborchuk

Copy link
Copy Markdown

Hi! Sorry for the question from the audience, but is it (using Copilot to review PR's in ASF projects) possible at all? We discussed it in Apache cloudberry apache/cloudberry#1740 and came to the conclusion that it is not possible right yet ) I personally use Copilot, but using personal license. If you guys could use it maybe I could once again suggest enable Copilot )

@wgtmac

wgtmac commented Jul 17, 2026

Copy link
Copy Markdown
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants