Skip to content

feat(22): uses corepack package loader for lambda build#129

Merged
dholmes merged 1 commit into
mainfrom
feature/docker-node-lambda-pnpm
Jun 5, 2025
Merged

feat(22): uses corepack package loader for lambda build#129
dholmes merged 1 commit into
mainfrom
feature/docker-node-lambda-pnpm

Conversation

@dholmes

@dholmes dholmes commented Jun 4, 2025

Copy link
Copy Markdown
Contributor

https://github.com/articulate/devex-sre/issues/1453

New Image Checklist

If you're adding a new image, make sure you have done the following:

  • Ensure Dockerfile has a # tag= comment with the correct tag(s)
  • Tag is added to README.md

@dholmes
dholmes marked this pull request as ready for review June 4, 2025 22:28
@dholmes
dholmes requested a review from a team as a code owner June 4, 2025 22:28
@ivorisoutdoors

Copy link
Copy Markdown
Contributor

What do we think about enabling corepack instead?

@dholmes

dholmes commented Jun 5, 2025

Copy link
Copy Markdown
Contributor Author

What do we think about enabling corepack instead?

@mgreystone I know you were looking at using corepack back in March. What led you to wanting to look into pnpm for building your lambdas?

@dholmes

dholmes commented Jun 5, 2025

Copy link
Copy Markdown
Contributor Author

What do we think about enabling corepack instead?

I think if we wanted to try corepack I'd feel better with a seperate lambda-corepack image so that we can leave out yarn (and pnpm) to avoid any conflict. Feeling good about this now. I didn't realize it shims the upstream tool names even if not installed.

@dholmes
dholmes force-pushed the feature/docker-node-lambda-pnpm branch from 3474d67 to 6122a0a Compare June 5, 2025 19:52
@dholmes dholmes changed the title feat(22): adds pnpm to the lambda build feat(22): uses codepack package loader for lambda build Jun 5, 2025
@dholmes
dholmes force-pushed the feature/docker-node-lambda-pnpm branch from 6122a0a to bb8ff10 Compare June 5, 2025 19:55
@dholmes

dholmes commented Jun 5, 2025

Copy link
Copy Markdown
Contributor Author

Tested locally - loads tools w/o prompting as default service user.

[service@67e5da7f1f58 service]$ yarn --version
1.22.22
[service@67e5da7f1f58 service]$ pnpm --version
10.11.1
[service@67e5da7f1f58 service]$ corepack --version
0.33.0
[service@67e5da7f1f58 service]$ 

@dholmes dholmes changed the title feat(22): uses codepack package loader for lambda build feat(22): uses corepack package loader for lambda build Jun 5, 2025
@dholmes
dholmes force-pushed the feature/docker-node-lambda-pnpm branch from bb8ff10 to 81ac993 Compare June 5, 2025 19:58
@dholmes
dholmes merged commit 6ac45fe into main Jun 5, 2025
22 checks passed
@dholmes
dholmes deleted the feature/docker-node-lambda-pnpm branch June 5, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants