feat(22): uses corepack package loader for lambda build#129
Merged
Conversation
dholmes
marked this pull request as ready for review
June 4, 2025 22:28
Contributor
|
What do we think about enabling corepack instead? |
Contributor
Author
@mgreystone I know you were looking at using corepack back in March. What led you to wanting to look into pnpm for building your lambdas? |
Contributor
Author
|
dholmes
force-pushed
the
feature/docker-node-lambda-pnpm
branch
from
June 5, 2025 19:52
3474d67 to
6122a0a
Compare
dholmes
force-pushed
the
feature/docker-node-lambda-pnpm
branch
from
June 5, 2025 19:55
6122a0a to
bb8ff10
Compare
Contributor
Author
|
Tested locally - loads tools w/o prompting as default service user. |
dholmes
force-pushed
the
feature/docker-node-lambda-pnpm
branch
from
June 5, 2025 19:58
bb8ff10 to
81ac993
Compare
ivorisoutdoors
approved these changes
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/articulate/devex-sre/issues/1453
New Image Checklist
If you're adding a new image, make sure you have done the following:
# tag=comment with the correct tag(s)