Fix dead token classes from shadcn compat cleanup#1975
Merged
Conversation
- Alert default variant used bg-card/text-card-foreground, tokens that were never defined — the classes compiled to nothing and the default Alert rendered without background or text color. Now uses bg-background/text-foreground. - Four components used focus-visible:ring-ring-3, referencing a nonexistent ring color token. Now focus-visible:ring-primary, consistent with other focus rings. - EmptyState glow shadows hardcoded hsl/rgba approximations of brand-300/red-300; now use shadow-brand-300/70 and shadow-red-300/70 so they track the palette. - CodeEditor Monaco theme hexes updated from Tailwind v3-era grays to the current zinc-based gray token values, with comments tying them to the design system.
kmcginnes
marked this pull request as ready for review
July 18, 2026 00:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes real visual bugs found during the cohesive review of the design system effort:
bg-card text-card-foregroundreferenced tokens that were never defined; default Alert rendered without background/text color. Nowbg-background text-foreground.focus-visible:ring-ring-3referenced a nonexistentringcolor token (broken shadcn leftover). Nowfocus-visible:ring-primary.hsl(205,95%,71%,70%)andrgba(255,144,119,0.7)instead of tracking the palette. Nowshadow-brand-300/70andshadow-red-300/70.Also updates the
/react-guidelinesskill's Tailwind section to referencedesign.mdinstead of the deletedtailwind.config.ts.Validation
pnpm checkspassespnpm testpasses (2178 tests)Related Issues
Check List
pnpm checkspasses with no errors.pnpm testpasses with no failures.