Fix --tree-suite-result selecting summary output#82
Open
94xhn wants to merge 1 commit into
Open
Conversation
The long tree-output option set only_test_suite_result while its -t alias set tree_test_suite_result. As a result, the documented long form printed the one-line suite summary instead of the nested result tree. Map both aliases to the same field and add a parser regression covering the selected and unselected output modes. Constraint: Long and short aliases must produce identical CommandLineOptions state. Rejected: Change the output dispatcher | the dispatcher already distinguishes the two valid modes correctly. Confidence: high Scope-risk: narrow Directive: Keep each command-line alias pair mapped to the same option field. Tested: baseline/fixed GCC 13 C++20 harness; command-line-arguments suite; 92-step CMake/Ninja build; full cest-runner exit 0; long/short nested-tree output match; git diff --check Not-tested: Quom single-header regeneration in this environment because Quom is not installed; CI installs it
94xhn
force-pushed
the
fix-tree-suite-long-option
branch
from
July 14, 2026 21:44
9eaf6ee to
386cb8d
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The documented
--tree-suite-resultoption setsonly_test_suite_result, while its short alias-tcorrectly setstree_test_suite_result.Because the output dispatcher checks the summary flag first, the long form prints only the one-line suite summary instead of the nested tree promised by the help text.
Fix
Map
--tree-suite-resulttotree_test_suite_result, matching-t, and add a command-line parser regression that checks both aliases select tree mode without selecting summary-only mode.Verification
--tree-suite-resultasonly=1 tree=0, while-tproducedonly=0 tree=1.only=0 tree=1.command-line-argumentstest executable, including the new regression, passes.cest-runnerreturned 0.--tree-suite-resultand-tproduces identical tree output.git diff --checkpasses.Quom is not installed in this local environment, so the CMake run used the repository multi-header source through a forwarding
build/cestheader. CI installs Quom and will additionally verify the generated single-header path.