Floor vulnerable transitive dependencies (Dependabot alerts)#12
Merged
Conversation
Resolve the 17 open Dependabot security alerts, all of which are transitive
dependencies (they cite settings.gradle.kts): Netty (via Lettuce), Jackson 2.x
and logback (via Dropwizard), commons-compress (via Testcontainers), and rhino
(via swagger-parser).
Rather than pin exact versions, raise each to its first patched release as a
*floor* via version-catalog-driven Gradle dependency constraints in
velocity.java-conventions (inherited by every module):
- platform(netty-bom) / platform(jackson2-bom) align each multi-artifact
family so we never split e.g. netty-handler 4.2.15 against netty-buffer
4.2.13.
- a constraints { } block floors the standalone coordinates (logback-core,
logback-classic, commons-compress, commons-lang3, rhino).
Floor (not pin) semantics mean a higher version reached by any other path still
wins, so future upgrades are never blocked — proven live: commons-lang3 floors
at 3.18.0 but still resolves to the higher transitive 3.20.0. All versions live
in libs.versions.toml, so the existing weekly Dependabot gradle job bumps them
forward automatically.
No source or velocity-spi/velocity-api contract changes (NFR-17 unaffected).
Verified: ./gradlew clean build test green incl. jacocoTestCoverageVerification;
dependencyInsight confirms every flagged artifact resolves at/above its patched
release.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Security tab shows 17 open Dependabot alerts, all against transitive dependencies (they cite
settings.gradle.kts, nothing we declare directly):io.netty:*(handler, resolver-dns, …)jackson-databind(2.x)logback-corecommons-compressrhinoA few alerts (
commons-lang33.20.0,jackson-core2.x) were already above their patched version and just needed a re-scan.Fix — floors, not pins
Version-catalog-driven Gradle dependency constraints in
velocity.java-conventions(inherited by every module):platform(netty-bom),platform(jackson2-bom)) keep each ~9–12-artifact family version-aligned — you can't run netty-handler 4.2.15 next to netty-buffer 4.2.13.constraints { }block floors the standalone libs.platform(...)/ plainrequiresemantics — notenforcedPlatform/strictly— so a higher version reached by any other path still wins. Future upgrades are never blocked. Proven live:commons-lang3floors at 3.18.0 but resolution still selects the higher transitive 3.20.0.libs.versions.toml, so the existing weekly Dependabotgradlejob bumps these floors forward automatically.Verification
./gradlew clean build testgreen, incl.jacocoTestCoverageVerification(re-run fresh with--rerun-tasks, no skipped gates).dependencyInsightconfirms every flagged artifact resolves at/above its patched release.velocity-spi/velocity-apicontract changes — NFR-17 (frozen SPI, additive-only) unaffected.change-validatorsub-agent → APPROVE.Once merged, the transitive graph GitHub resolves will meet the floors and the alerts close on the next scan.
🤖 Generated with Claude Code