Merge competition result sources safely#83
Merged
Conversation
Match WCA Live and API results with authoritative identities and ambiguity-safe fallbacks. Preserve merged result metadata without carrying stale attempt indexes.
✅ Deploy Preview for competition-groups ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
WCA Live can omit a registrant ID, and the previous name fallback could attach results to the wrong competitor when names were duplicated. WCA API matching could also select an earlier same-name person before the exact WCA ID. Broad result-object merging additionally retained stale dropped-attempt indexes after newer results replaced the attempts.
Impact
Results remain linked to the correct competitor, ambiguous rows stay safely unlinked, and newer WCIF/WCA Live attempts no longer inherit stale display metadata.
Validation
yarn test --runInBand(35 suites, 160 tests)yarn check:typeyarn lint(0 errors; 4 pre-existing warnings)yarn build