Sync main into beta#84
Merged
Merged
Conversation
Deploy beta to production
Change shortName for Megaminx from 'Minx' to 'Mega'
…atch assignment to persons actual assignment
Fixing bugs for nac
Preserve the Worlds extra-assignment behavior alongside the NAC/FMC fixes. Use venue-consistent schedule dates and add reconciliation coverage before production release.
✅ Deploy Preview for competition-groups ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainback intobetaother-miscactivities and keep extra-only schedule daysWhy
The existing
beta→maindeploy PR conflicted in Personal Schedule logic. A mechanical choice of either side would regress either Worlds assignments or the production FMC fixes. The extra-only-day behavior also exposed inconsistent timezone resolution that could make an assignment disappear near a UTC date boundary.Impact
betanow contains all current production fixes, the deploy conflict is resolved, and Worlds/FMC-only schedule days remain visible on the correct venue-local date.Validation
TZ=UTC yarn test --runInBand src/containers/PersonalSchedule/utils.test.ts(6 tests)yarn test --runInBand(35 suites, 164 tests)yarn check:typeyarn lint(0 errors; 4 pre-existing warnings)yarn build