fix(#3394): add explicit gomod fileMatch for all go.mod files#3395
fix(#3394): add explicit gomod fileMatch for all go.mod files#3395fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
Add gomod manager-level fileMatch configuration to renovate.json to ensure Renovate consistently discovers and updates dependencies across all go.mod files in this multi-module repository, including tools/go.mod. Renovate PR #3378 updated oras.land/oras-go/v2 in go.mod and acceptance/go.mod but missed tools/go.mod, requiring a manual follow-up PR #3391. By explicitly setting the fileMatch pattern for the gomod manager, we make the intent to cover all module directories explicit in the repo configuration rather than relying solely on Renovate defaults. Closes #3394
|
🤖 Finished Review · ✅ Success · Started 4:01 PM UTC · Completed 4:07 PM UTC |
ReviewVerdict: approve — safe, low-risk configuration change. SummaryThis PR adds an explicit AnalysisCorrectness: The regex pattern is correct and matches all four Potential limitation (low): The pattern The original issue (#3394) describes If the missed update recurs after this change lands, the next step would be to investigate Renovate's handling of indirect dependencies across separate Go modules, potentially adding Security: No concerns — this is a build-tooling configuration change with no runtime impact. Scope & intent: The change is appropriately scoped to the linked issue #3394 and modifies only the Renovate configuration file. No injection patterns detected in PR body, commit messages, or linked issue text. Labels: PR modifies Renovate configuration for Go module dependency management |
| "extends": [ | ||
| "github>conforma/.github//config/renovate/renovate.json" | ||
| ], | ||
| "gomod": { |
There was a problem hiding this comment.
[low] correctness
The fileMatch pattern (^|/)go.mod$ is identical to Renovate gomod manager built-in default. The shared preset does not override gomod fileMatch, so this explicit setting is likely redundant. The root cause of tools/go.mod being missed (issue #3394) may be that oras.land/oras-go/v2 is an indirect dependency in tools/go.mod and Renovate does not track indirect-only dependencies across separate Go modules. If the issue recurs, consider adding postUpgradeTasks to run go mod tidy across all module directories.
Suggested fix: Monitor the next Renovate scan that includes a dependency present in tools/go.mod. If tools/go.mod is still missed, investigate Renovate indirect dependency handling in multi-module repos and consider postUpgradeTasks or per-module packageRules.
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Add gomod manager-level fileMatch configuration to renovate.json to ensure Renovate consistently discovers and updates dependencies across all go.mod files in this multi-module repository, including tools/go.mod.
Renovate PR #3378 updated oras.land/oras-go/v2 in go.mod and acceptance/go.mod but missed tools/go.mod, requiring a manual follow-up PR #3391. By explicitly setting the fileMatch pattern for the gomod manager, we make the intent to cover all module directories explicit in the repo configuration rather than relying solely on Renovate defaults.
Closes #3394
Post-script verification
agent/3394-renovate-gomod-filematch)5759bb21f606d6fb51f2c078de41d3cf9e0962f7..HEAD)