Skip to content

fix: stabilize Pages validation #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yyyyaaa merged 2 commits into from
Jul 15, 2026
Merged

fix: stabilize Pages validation #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
416c160
test: stabilize phone resend countdown
yyyyaaa Jul 15, 2026
66ec6fd
test: isolate resend timer cleanup
yyyyaaa Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions apps/blocks/src/blocks/auth/account-phones-list/account-phones-list.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,6 +415,8 @@ describe('AccountPhonesList', () => {

it('resend countdown decrements to zero, restarts, and cleans up on unmount', async () => {
vi.useFakeTimers();
const setTimeoutSpy = vi.spyOn(globalThis, 'setTimeout');
const clearTimeoutSpy = vi.spyOn(globalThis, 'clearTimeout');
const onSubmitSendOtp = vi.fn().mockResolvedValue(undefined);
phonesQueryDataMock.mockReturnValue({
phoneNumbers: {
Expand All @@ -430,13 +432,11 @@ describe('AccountPhonesList', () => {
const resendButton = screen.getByTestId('otp-resend-p5');
expect(resendButton).toHaveTextContent('Resend in 60s');
expect(resendButton).toBeDisabled();
expect(vi.getTimerCount()).toBe(1);

await act(async () => {
vi.advanceTimersByTime(1000);
});
expect(resendButton).toHaveTextContent('Resend in 59s');
expect(vi.getTimerCount()).toBe(1);

for (let second = 0; second < 59; second += 1) {
await act(async () => {
Expand All @@ -445,17 +445,25 @@ describe('AccountPhonesList', () => {
}
expect(resendButton).toHaveTextContent('Resend code');
expect(resendButton).not.toBeDisabled();
expect(vi.getTimerCount()).toBe(0);

await act(async () => {
fireEvent.click(resendButton);
});
expect(onSubmitSendOtp).toHaveBeenCalledTimes(2);
expect(resendButton).toHaveTextContent('Resend in 60s');
expect(vi.getTimerCount()).toBe(1);

const countdownTimerIndex = setTimeoutSpy.mock.calls.reduce(
(latestIndex, call, index) => (call[1] === 1000 ? index : latestIndex),
-1
);
expect(countdownTimerIndex).toBeGreaterThanOrEqual(0);
const countdownTimer = setTimeoutSpy.mock.results[countdownTimerIndex]?.value;
clearTimeoutSpy.mockClear();

unmount();
expect(vi.getTimerCount()).toBe(0);
expect(clearTimeoutSpy).toHaveBeenCalledWith(countdownTimer);
setTimeoutSpy.mockRestore();
clearTimeoutSpy.mockRestore();
});

it('verify inline without onSubmitSendOtp: surfaces PROCEDURE_NOT_FOUND', async () => {
Expand Down
Loading