feat: add SMS verification code flow#113
Draft
Zetazzz wants to merge 2 commits into
Draft
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
send-smsjob function and typed provider abstraction/api/sms/send/twilioFnGeneratorbyte-identical with the repository generator for recursive support files and stable auto-assigned portsValidation
pnpm install --frozen-lockfilepnpm test:unit -- --runInBand(8 suites; 43 passed, 6 todo)pnpm --filter @constructive-io/fn-generator test(3 passed)pnpm --filter @constructive-io/fn-client test(3 passed)pnpm --filter @constructive-io/fn-cli test(7 passed)pnpm build(all 13 buildable workspace projects)git diff --checkDependency
Depends on constructive-io/constructive#1383 for the typed SMS configuration exported by
@constructive-io/graphql-envand@constructive-io/graphql-types.Until both PRs are merged and their packages are published, constructive-hub#580 pins these exact feature commits and links the local packages for end-to-end validation.