fix: replace bare raise with ToolUsageError in _original_tool_calling (#6430)#6589
Open
fazalpsinfo-cmyk wants to merge 1 commit into
Open
fix: replace bare raise with ToolUsageError in _original_tool_calling (#6430)#6589fazalpsinfo-cmyk wants to merge 1 commit into
fazalpsinfo-cmyk wants to merge 1 commit into
Conversation
A bare `raise` at line 853 is outside any exception handler, causing RuntimeError when arguments is not a dict. Replaced with ToolUsageError. Closes crewAIInc#6430
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesTool input error handling
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A bare
raisein_original_tool_calling()at line 853 is outside any exception handler. Whenargumentsis not a dict, this causesRuntimeError: No active exception to re-raiseinstead of a meaningful error.Fix
Replaced the bare
raisewithraise ToolUsageError(...), matching the error path that already exists in the non-raise branch.Closes #6430
Support my work: https://buymeacoffee.com/muhamedfazalps