Make ssh_jump a DSN query parameter#2000
Merged
Merged
Conversation
Making ssh_jump a DSN query parameter allows DSNs which depend on an SSH jump to be saved as aliases in ~/.myclirc. If --ssh-jump is given at the CLI, it overrides the value in the DSN, as with _eg_ port and socket. ssh_options is not included in the DSN at this time. Future work should include warnings when unknown query parameters are included in DSNs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Making
ssh_jumpa DSN query parameter allows DSNs which depend on an SSH jump to be saved as aliases in~/.myclirc.If
--ssh-jumpis given at the CLI, it overrides the value in the DSN, as with eg port and socket.ssh_optionsis not included in the DSN at this time.Future work should include warnings when unknown query parameters are included in DSNs.
Checklist
changelog.mdfile.AUTHORSfile (or it's already there).