Attempting a fix for inconsistency in text gradient clamp logic between iOS and Android.#17
Draft
andrewkunkel wants to merge 1 commit into
Draft
Attempting a fix for inconsistency in text gradient clamp logic between iOS and Android.#17andrewkunkel wants to merge 1 commit into
andrewkunkel wants to merge 1 commit into
Conversation
…d, rather than abruptly looping the gradient.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the gradientMode prop we added to text gradient, there's a platform-specific discrepancy between how it interacts with gradientLength when the provided length is too short:
Android: The final color of the gradient is extended indefinitely.
iOS: The gradient starts over at the first color.
See Android left, iOS right.
This is an existing discrepancy in the platform gradient logic, not part of the code we introduced. Android natively supports both clamp and mirror modes, while on iOS clamp is the only mode and we had to add support for mirrored text gradients. But neither platform had text gradients out of the box.