[build] Fix stabilized SDK workload manifest path#12192
Open
jonathanpeppers wants to merge 2 commits into
Open
[build] Fix stabilized SDK workload manifest path#12192jonathanpeppers wants to merge 2 commits into
jonathanpeppers wants to merge 2 commits into
Conversation
Derive the loose workload manifest folder from NETCoreSdkVersion so stabilized SDK installs use the product feature band rather than the prerelease package version. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c61e4369-db2e-4ce1-894a-cda1324f6f58
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the local workload manifest installation logic to derive the sdk-manifests feature band from the installed SDK version (NETCoreSdkVersion), fixing scenarios where “stabilized” SDK builds keep a prerelease package version that would otherwise point to the wrong manifest directory.
Changes:
- Add
_DetermineLocalSdkFeatureBandtarget to compute the SDK feature band fromNETCoreSdkVersion(including selective prerelease handling). - Update
InstallManifestAndDependenciesto use the computed feature band forlib\sdk-manifests\...lookup. - Add an explicit error when the feature band cannot be determined.
Keep malformed SDK versions empty so the feature-band validation reports a clear error instead of creating an invalid prerelease-only path. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c61e4369-db2e-4ce1-894a-cda1324f6f58
jonathanpeppers
added
the
ready-to-review
rolfbjarne
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #12180 exposed a mismatch in stabilized SDK builds:
MicrosoftNETSdkPackageVersionremained10.0.400-preview.0.26367.110, whiledotnet-installdownloaded an SDK whose actualNETCoreSdkVersionand product directory were10.0.400. The package-derived loose manifest path was thereforesdk-manifests/10.0.400-preview.0, but the installed SDK searchedsdk-manifests/10.0.400, sodotnet workload install android-depscould not discover the Android manifest.Derive the local manifest feature band from
NETCoreSdkVersion, matching the installed SDK'sSdkFeatureBandbehavior: round servicing patches to the X00 band, preserve the first two public prerelease components, and omit dev/ci/rtm prerelease labels. Emit a clear error when the feature band cannot be determined.