fix: remove outdated stop_and_shutdown_loop from Worker docstring#673
Open
nightcityblade wants to merge 3 commits into
Open
fix: remove outdated stop_and_shutdown_loop from Worker docstring#673nightcityblade wants to merge 3 commits into
nightcityblade wants to merge 3 commits into
Conversation
Contributor
Author
|
Gentle ping — any thoughts on this? Happy to address feedback if needed. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #673 +/- ##
=======================================
Coverage 94.14% 94.14%
=======================================
Files 104 104
Lines 11136 11136
Branches 1201 1201
=======================================
Hits 10484 10484
Misses 551 551
Partials 101 101 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #317
The Worker class docstring referenced
stop_and_shutdown_loop()in example 3, but this method no longer exists. The Worker registers signal handlers on start, so explicit cleanup in afinallyblock is unnecessary.Removed the outdated
try/finallyblock and the reference tostop_and_shutdown_loop()from the docstring example.