Skip to content

fix: update is_union function to support python 3.10+ union syntax #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wbarnha merged 2 commits into from
Jul 17, 2026
+14 −9
Merged

fix: update is_union function to support python 3.10+ union syntax #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c88d05
fix: update is_union function to support python 3.10+ union syntax
NJABULO-NDLOVU Apr 4, 2025
e074b95
test: only use X | Y union syntax on Python 3.10+
claude Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions mode/utils/objects.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,6 +472,7 @@ def is_union(typ: Type) -> bool:
name = typ.__class__.__name__
return any(
[
name == "UnionType", # 3.10
name == "_UnionGenericAlias", # 3.9
name == "_GenericAlias" and typ.__origin__ is typing.Union, # 3.7
name == "_Union", # 3.6
Expand Down
22 changes: 13 additions & 9 deletions tests/unit/utils/test_objects.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import abc
import collections.abc
import pickle
import sys
import typing
from typing import (
AbstractSet,
Expand Down Expand Up @@ -377,14 +378,17 @@ def test_label_pass():
assert label(s) is s


@pytest.mark.parametrize(
"input,expected",
[
(str, False),
(int, False),
(Union[int, bytes], True),
(Optional[str], True),
],
)
IS_UNION_CASES = [
(str, False),
(int, False),
(Union[int, bytes], True),
(Optional[str], True),
]
if sys.version_info >= (3, 10):
# X | Y syntax is only usable at runtime on Python 3.10+
IS_UNION_CASES.append((int | None, True))


@pytest.mark.parametrize("input,expected", IS_UNION_CASES)
def test_is_union(input, expected):
assert is_union(input) == expected
Loading