feat(webhook): add reviewer name to MS Teams review request notifications

[SudhanshuMatrix]

Summary

Include the requested reviewer's username (along with their full name in parentheses, if available) and render the Repository and Pull request fields as clickable links in Microsoft Teams webhook notifications.

Fixes: #38270

Changes

• services/webhook/msteams.go:
  • Updated the createMSTeamsPayload helper function to globally format the Repository: fact as a clickable markdown link using the repository's full name and HTML URL.
  • Updated the PullRequest convertor to format the requested reviewer as Username (Full Name) (falling back to just Username if the full name is empty) and append a new Requested Reviewer: fact when the action is a review request or removal.
  • Updated the PullRequest and Review convertors to format the Pull request: fact as a clickable markdown link using the PR index and HTML URL.
  • Cleaned up the duplicate manual Repository: fact from the Wiki converter since the shared helper now automatically generates the formatted link.
• services/webhook/msteams_test.go:
  • Updated the test suite assertions to expect the new markdown link formats for all repository and pull request facts.

Verification

• Ran unit tests successfully:

  go test ./services/webhook/

[bircni]

Any UI example?

[SudhanshuMatrix]

@bircni Since MessageCards are a legacy format and Microsoft recommends using Adaptive Cards for new Microsoft Teams development, I couldn't find a way to preview the MessageCard JSON directly. As a workaround, I converted the MessageCard JSON payload into an Adaptive Card. The converted card renders successfully

Do you happen to have access to a Microsoft Developer Sandbox or the credentials for one? If so, we could use it to test this in a Microsoft 365 environment.

I applied for a Microsoft Developer Sandbox earlier, but it seems Microsoft isn't granting sandbox subscriptions to new users at the moment, so I wasn't able to get access. If you already have one available, it would be really helpful for testing.

[itxaiohanglover]

Nice implementation — the variadic extraFacts ... refactoring is clean and the reviewer name fallback from FullName to UserName is correct. Test coverage for the review request case is good.

[SudhanshuMatrix]

It would be great if this could be tested manually. Currently, the MessageCard JSON is converted to an Adaptive Card only to provide a rough preview. See the comment for more details: #38289 (comment).

If anyone has access to a Microsoft Developer Sandbox (or other testing credentials), I'd really appreciate your help testing this. Alternatively, if someone can test it manually and confirm whether everything works as expected, that would be very helpful. Thanks!

[bircni]

It would be great if this could be tested manually. Currently, the MessageCard JSON is converted to an Adaptive Card only to provide a rough preview. See the comment for more details: #38289 (comment).

If anyone has access to a Microsoft Developer Sandbox (or other testing credentials), I'd really appreciate your help testing this. Alternatively, if someone can test it manually and confirm whether everything works as expected, that would be very helpful. Thanks!

can't you just post it into your teams team?

[SudhanshuMatrix]

The issue poster is already helping (see #38270). I'm on Linux and only use the Teams web client, and I don't see any option there to post or preview MessageCard JSON. I don't know whether that is a web-client limitation, a tenant/permission restriction, or a premium feature. I attached an Adaptive Card preview earlier as a rough reference.