fix(events/natsjs): default to auto ack#165
Open
grechny wants to merge 1 commit into
Open
Conversation
Match the documented events contract and other stream implementations. Fixes go-micro#164 Signed-off-by: Aliaksandr Hrechny <8013455+grechny@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Default NATS JetStream event consumers to automatic acknowledgement, matching
the documented
events.ConsumeOptionscontract and the NATS Streaming andin-memory event implementations.
Without this initialization, the
AutoAckzero value creates anAckExplicitdurable consumer. Callers relying on the documented default thenaccumulate pending messages and redeliveries under load.
The regression test inspects the JetStream consumer configuration and covers
both the default and the explicit manual-ack override.
Fixes #164
Testing
Result:
ok github.com/go-micro/plugins/v4/events/natsjsChecklist