runtime: remove unused frag calculation in ASAN poisoning#80126
runtime: remove unused frag calculation in ASAN poisoning#80126qinlonglong123 wants to merge 1 commit into
Conversation
The variable frag is computed but never used in the ASAN poisoning logic below. The code calculates the fragment size between the actual allocation slot and the requested size, optionally adjusting for the malloc header, but the result is discarded. Remove this dead code since asanpoison and asanunpoison only require size and asanRZ.
|
This PR (HEAD: 9eb7bd6) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/793580. Important tips:
|
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/793580. |
|
Message from Keith Randall: Patch Set 2: Auto-Submit+1 Code-Review+2 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/793580. |
|
Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2026-06-24T15:42:32Z","revision":"abaa115b631595164511cde8549f62a50c7f2b37"} Please don’t reply on this GitHub thread. Visit golang.org/cl/793580. |
|
Message from Keith Randall: Patch Set 2: -Commit-Queue (Performed by <GERRIT_ACCOUNT_60063> on behalf of <GERRIT_ACCOUNT_5200>) Please don’t reply on this GitHub thread. Visit golang.org/cl/793580. |
|
Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com: Patch Set 2: This CL has failed the run. Reason: Tryjob golang/try/gotip-linux-amd64_debiansid has failed with summary (view all results):
To reproduce, try Additional links for debugging: Please don’t reply on this GitHub thread. Visit golang.org/cl/793580. |
|
Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com: Patch Set 2: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/793580. |
|
Message from Keith Randall: Patch Set 2: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/793580. |
|
Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2026-06-24T22:30:06Z","revision":"abaa115b631595164511cde8549f62a50c7f2b37"} Please don’t reply on this GitHub thread. Visit golang.org/cl/793580. |
|
Message from Keith Randall: Patch Set 2: -Commit-Queue (Performed by <GERRIT_ACCOUNT_60063> on behalf of <GERRIT_ACCOUNT_5200>) Please don’t reply on this GitHub thread. Visit golang.org/cl/793580. |
|
Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com: Patch Set 2: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/793580. |
|
Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com: Patch Set 2: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/793580. |
|
Message from 秦龙: Patch Set 2: Code-Review+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/793580. |
|
Message from Keith Randall: Patch Set 2: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/793580. |
The variable frag is computed but never used in the ASAN poisoning logic below.
The code calculates the fragment size between the actual allocation slot and the requested size, optionally adjusting for the malloc header, but the result is discarded.
Remove this dead code since asanpoison and asanunpoison only require size and asanRZ.