internal/poll: document why zero-byte reads do not wait for readability#80244
internal/poll: document why zero-byte reads do not wait for readability#80244fyzanshaik wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
3d5b086 to
b2e0819
Compare
The TODO asked whether a zero-byte Read should wait for readability. CL 22031 proposed that behavior and was abandoned. Blocking would change the behavior of existing callers, and the netpoller's edge-triggered notifications alone cannot detect data that is already buffered. Replace the stale TODO with the outcome. Updates golang#15735
b2e0819 to
0c3e22b
Compare
|
This PR (HEAD: 0c3e22b) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/796620. Important tips:
|
|
Message from Ian Lance Taylor: Patch Set 1: Auto-Submit+1 Code-Review+2 Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/796620. |
|
Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2026-07-02T19:01:46Z","revision":"db1fec01dc5cca6b3679c73f2938d9235db6a52e"} Please don’t reply on this GitHub thread. Visit golang.org/cl/796620. |
|
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/796620. |
|
Message from Ian Lance Taylor: Patch Set 1: -Commit-Queue (Performed by <GERRIT_ACCOUNT_60063> on behalf of <GERRIT_ACCOUNT_5206>) Please don’t reply on this GitHub thread. Visit golang.org/cl/796620. |
|
Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com: Patch Set 1: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/796620. |
|
Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com: Patch Set 1: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/796620. |
The TODO asked whether a zero-byte Read should wait for readability.
CL 22031 proposed that behavior and was abandoned. Blocking would
change the behavior of existing callers, and the netpoller's
edge-triggered notifications alone cannot detect data that is
already buffered. Replace the stale TODO with the outcome.
Updates #15735