Skip to content

reflect: acknowledge ValueError applies to non-receiver arguments#80246

Open
larrasket wants to merge 1 commit into
golang:masterfrom
larrasket:reflect-valueerror-wording
Open

reflect: acknowledge ValueError applies to non-receiver arguments#80246
larrasket wants to merge 1 commit into
golang:masterfrom
larrasket:reflect-valueerror-wording

Conversation

@larrasket

@larrasket larrasket commented Jul 2, 2026

Copy link
Copy Markdown

ValueError is used to report both receiver and non-receiver arguments,
but its message assumed the receiver, producing misleading panics such
as

reflect: call of reflect.Value.Set on zero Value

for v.Set(reflect.Value{}), where the zero Value is the argument, not
the receiver. Say "with" instead of "on" so the message doesn't point
at the receiver, and update the ValueError doc comment to match.

Revives CL 262157 by Toni Cárdenas, with the test expectations updated
and a regression test added.

Fixes #41953

ValueError is used to report both receiver and non-receiver arguments,
but its message assumed the receiver, producing misleading panics such
as

    reflect: call of reflect.Value.Set on zero Value

for v.Set(reflect.Value{}), where the zero Value is the argument, not
the receiver. Say "with" instead of "on" so the message doesn't point
at the receiver, and update the ValueError doc comment to match.

Revives CL 262157 by Toni Cárdenas, with the test expectations updated
and a regression test added.

Fixes golang#41953
@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: a3c5943) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/796700.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/796700.
After addressing review feedback, remember to publish your drafts!

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Salih Gabbir:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/796700.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

reflect: Set: argument validation panics with ValueError, which is for receiver

2 participants