reflect: acknowledge ValueError applies to non-receiver arguments#80246
Open
larrasket wants to merge 1 commit into
Open
reflect: acknowledge ValueError applies to non-receiver arguments#80246larrasket wants to merge 1 commit into
larrasket wants to merge 1 commit into
Conversation
ValueError is used to report both receiver and non-receiver arguments,
but its message assumed the receiver, producing misleading panics such
as
reflect: call of reflect.Value.Set on zero Value
for v.Set(reflect.Value{}), where the zero Value is the argument, not
the receiver. Say "with" instead of "on" so the message doesn't point
at the receiver, and update the ValueError doc comment to match.
Revives CL 262157 by Toni Cárdenas, with the test expectations updated
and a regression test added.
Fixes golang#41953
Contributor
|
This PR (HEAD: a3c5943) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/796700. Important tips:
|
Contributor
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/796700. |
Contributor
|
Message from Salih Gabbir: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/796700. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ValueError is used to report both receiver and non-receiver arguments,
but its message assumed the receiver, producing misleading panics such
as
for v.Set(reflect.Value{}), where the zero Value is the argument, not
the receiver. Say "with" instead of "on" so the message doesn't point
at the receiver, and update the ValueError doc comment to match.
Revives CL 262157 by Toni Cárdenas, with the test expectations updated
and a regression test added.
Fixes #41953