feat: use assets ambient types from app-builder#7
Merged
Conversation
Updated app-builder version Dropped assets type definitions from templates Added app-builder ui ambient types in typescript template Refs: gravity-ui/app-builder#333
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the app-builder integration to use ambient UI asset types provided by @gravity-ui/app-builder instead of template-defined asset typings, and bumps the app-builder dev dependency accordingly. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The app-builder version string is duplicated between the generator and tests; consider centralizing it in a single constant to avoid having to update multiple locations on version bumps.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The app-builder version string is duplicated between the generator and tests; consider centralizing it in a single constant to avoid having to update multiple locations on version bumps.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
ogonkov
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated app-builder version
Dropped assets type definitions from templates
Added app-builder ui ambient types in typescript template
Refs: gravity-ui/app-builder#333
Summary by Sourcery
Update app-builder integration to rely on ambient UI types from the app-builder package instead of locally generated asset type declarations.
New Features:
Enhancements:
Build:
Documentation:
Tests: