Create dedicated controllers for each model to lighten studyController file#1019
Open
basseche wants to merge 8 commits into
Open
Create dedicated controllers for each model to lighten studyController file#1019basseche wants to merge 8 commits into
basseche wants to merge 8 commits into
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughLoad-flow endpoints move from ChangesLoad-flow controller extraction
Sequence Diagram(s)sequenceDiagram
participant Client
participant LoadFlowController
participant StudyService
participant LoadFlowServiceRest
Client->>LoadFlowController: Start or rerun load-flow
LoadFlowController->>StudyService: Validate and orchestrate execution
StudyService->>LoadFlowServiceRest: Create status and run load-flow
LoadFlowServiceRest-->>StudyService: Return computation response
StudyService-->>LoadFlowController: Complete request
LoadFlowController-->>Client: Return HTTP response
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/test/java/org/gridsuite/study/server/loadflow/LoadFLowUnitTest.java (1)
95-95: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick winFix parameter order for
runLoadFlow.The
nodeUuidandrootNetworkUuidparameters are swapped in this method call.LoadFlowController.runLoadFlowexpects the order to bestudyUuid, rootNetworkUuid, nodeUuid(as correctly done on line 111).While this test currently passes because the assertions use
any()matchers, the incorrect order should be fixed to prevent confusion and test failures if stricter matchers are introduced in the future.💡 Proposed fix
- controller.runLoadFlow(studyUuid, nodeUuid, rootNetworkUuid, false, userId); + controller.runLoadFlow(studyUuid, rootNetworkUuid, nodeUuid, false, userId);🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/test/java/org/gridsuite/study/server/loadflow/LoadFLowUnitTest.java` at line 95, Update the runLoadFlow call in LoadFLowUnitTest so its arguments follow LoadFlowController.runLoadFlow’s expected order: studyUuid, rootNetworkUuid, then nodeUuid, matching the correct invocation elsewhere in the test.
🧹 Nitpick comments (3)
src/main/java/org/gridsuite/study/server/controller/DynamicSimulationController.java (2)
155-155: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueRemove
contentTypefrom the bodyless response.Setting the
Content-Typeheader (toapplication/json) on a response that has no body (build()) is semantically incorrect in HTTP.♻️ Proposed fix
- return ResponseEntity.ok().contentType(MediaType.APPLICATION_JSON).build(); + return ResponseEntity.ok().build();🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/main/java/org/gridsuite/study/server/controller/DynamicSimulationController.java` at line 155, Update the bodyless response in DynamicSimulationController to remove the contentType(MediaType.APPLICATION_JSON) call, returning the ResponseEntity from ok().build() while preserving the existing status and no-body behavior.
91-99: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueDocument the
204 No Contentresponse.The implementation correctly returns a
204 No Contentresponse when the event is not found, but this is not documented in the@ApiResponses. Please add the204response to keep the OpenAPI specification accurate.📝 Proposed fix
`@ApiResponses`(value = { `@ApiResponse`(responseCode = "200", description = "The dynamic simulation event was returned"), + `@ApiResponse`(responseCode = "204", description = "The dynamic simulation event was not found"), `@ApiResponse`(responseCode = "404", description = "The study/node is not found")}) public ResponseEntity<EventInfos> getDynamicSimulationEvent(`@Parameter`(description = "Study UUID") `@PathVariable`("studyUuid") UUID studyUuid,🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/main/java/org/gridsuite/study/server/controller/DynamicSimulationController.java` around lines 91 - 99, Add an `@ApiResponse` for HTTP 204 No Content to getDynamicSimulationEvent, documenting the no-body response returned when studyService.getDynamicSimulationEvent yields no event, while preserving the existing 200 and 404 responses.src/main/java/org/gridsuite/study/server/controller/LoadFlowController.java (1)
79-84: 🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick winPrevent the manual rollback from masking the original exception.
If
studyService.deleteLoadflowResult(...)fails and throws an exception inside thiscatchblock, it will swallow the original exceptione. Consider wrapping the rollback in a nestedtry-catchand attaching its exception as suppressed, ensuring the root cause of the failure is not lost.🛡️ Proposed fix
} catch (Exception e) { if (loadflowResultUuid != null) { - studyService.deleteLoadflowResult(studyUuid, nodeUuid, rootNetworkUuid, loadflowResultUuid); + try { + studyService.deleteLoadflowResult(studyUuid, nodeUuid, rootNetworkUuid, loadflowResultUuid); + } catch (Exception deletionException) { + e.addSuppressed(deletionException); + } } throw e; }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/main/java/org/gridsuite/study/server/controller/LoadFlowController.java` around lines 79 - 84, Update the exception handler in LoadFlowController so the cleanup call to studyService.deleteLoadflowResult is wrapped in a nested try-catch; if rollback fails, attach that failure as suppressed to the original exception e, then always rethrow e so the root cause is preserved.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@src/main/java/org/gridsuite/study/server/controller/SecurityAnalysisController.java`:
- Around line 76-90: Update SecurityAnalysisController.getSecurityAnalysisResult
to return ResponseEntity<byte[]>, return noContent when the service result is
null, and set Content-Type and Content-Disposition headers for successful CSV
downloads. In SensitivityAnalysisController’s CSV export endpoint, add the same
null-result check and return ResponseEntity.noContent().build(); apply changes
at
src/main/java/org/gridsuite/study/server/controller/SecurityAnalysisController.java
lines 76-90 and
src/main/java/org/gridsuite/study/server/controller/SensitivityAnalysisController.java
lines 85-102.
---
Outside diff comments:
In `@src/test/java/org/gridsuite/study/server/loadflow/LoadFLowUnitTest.java`:
- Line 95: Update the runLoadFlow call in LoadFLowUnitTest so its arguments
follow LoadFlowController.runLoadFlow’s expected order: studyUuid,
rootNetworkUuid, then nodeUuid, matching the correct invocation elsewhere in the
test.
---
Nitpick comments:
In
`@src/main/java/org/gridsuite/study/server/controller/DynamicSimulationController.java`:
- Line 155: Update the bodyless response in DynamicSimulationController to
remove the contentType(MediaType.APPLICATION_JSON) call, returning the
ResponseEntity from ok().build() while preserving the existing status and
no-body behavior.
- Around line 91-99: Add an `@ApiResponse` for HTTP 204 No Content to
getDynamicSimulationEvent, documenting the no-body response returned when
studyService.getDynamicSimulationEvent yields no event, while preserving the
existing 200 and 404 responses.
In `@src/main/java/org/gridsuite/study/server/controller/LoadFlowController.java`:
- Around line 79-84: Update the exception handler in LoadFlowController so the
cleanup call to studyService.deleteLoadflowResult is wrapped in a nested
try-catch; if rollback fails, attach that failure as suppressed to the original
exception e, then always rethrow e so the root cause is preserved.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 7c548ae7-b9d5-4249-991b-a75b2ef975de
📒 Files selected for processing (10)
src/main/java/org/gridsuite/study/server/controller/DynamicSimulationController.javasrc/main/java/org/gridsuite/study/server/controller/LoadFlowController.javasrc/main/java/org/gridsuite/study/server/controller/PccMinController.javasrc/main/java/org/gridsuite/study/server/controller/SecurityAnalysisController.javasrc/main/java/org/gridsuite/study/server/controller/SensitivityAnalysisController.javasrc/main/java/org/gridsuite/study/server/controller/ShortCircuitController.javasrc/main/java/org/gridsuite/study/server/controller/StateEstimationController.javasrc/main/java/org/gridsuite/study/server/controller/StudyController.javasrc/main/java/org/gridsuite/study/server/controller/VoltageInitController.javasrc/test/java/org/gridsuite/study/server/loadflow/LoadFLowUnitTest.java
Signed-off-by: basseche <bassel.el-cheikh_externe@rte-france.com>
basseche
force-pushed
the
refactor_study_controller
branch
from
July 16, 2026 11:38
4fb8da6 to
8c6088c
Compare
basseche
changed the title
basseche
changed the title
There was a problem hiding this comment.
🧹 Nitpick comments (2)
src/main/java/org/gridsuite/study/server/controller/loadflow/LoadFlowController.java (2)
121-122: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueUpdate API response descriptions to match the endpoint.
The descriptions for the responses mention "computation infos" instead of "modifications", which appears to be a copy-paste oversight from the
/computation-infosendpoint.📝 Proposed fix
- `@ApiResponses`(value = {`@ApiResponse`(responseCode = "200", description = "The loadflow computation infos"), - `@ApiResponse`(responseCode = "404", description = "The loadflow computation has not been found")}) + `@ApiResponses`(value = {`@ApiResponse`(responseCode = "200", description = "The loadflow modifications"), + `@ApiResponse`(responseCode = "404", description = "The loadflow modifications have not been found")})🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/main/java/org/gridsuite/study/server/controller/loadflow/LoadFlowController.java` around lines 121 - 122, Update the `@ApiResponses` annotation on the relevant LoadFlowController endpoint so the 200 response description refers to loadflow modifications rather than computation infos, while leaving the 404 description unchanged.
74-79: 🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick winPrevent original exception masking during rollback.
If
studyService.deleteLoadflowResultthrows an exception, it will mask the original exceptionethat caused the failure. Wrapping the rollback in a try-catch and usingaddSuppressedensures the original failure cause is preserved for debugging.♻️ Proposed fix
} catch (Exception e) { if (loadflowResultUuid != null) { - studyService.deleteLoadflowResult(studyUuid, nodeUuid, rootNetworkUuid, loadflowResultUuid); + try { + studyService.deleteLoadflowResult(studyUuid, nodeUuid, rootNetworkUuid, loadflowResultUuid); + } catch (Exception ex) { + e.addSuppressed(ex); + } } throw e; }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/main/java/org/gridsuite/study/server/controller/loadflow/LoadFlowController.java` around lines 74 - 79, Update the catch block in the LoadFlowController flow to wrap studyService.deleteLoadflowResult in its own try-catch when loadflowResultUuid is non-null; if rollback fails, attach that rollback exception to the original exception e using addSuppressed, then rethrow e unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In
`@src/main/java/org/gridsuite/study/server/controller/loadflow/LoadFlowController.java`:
- Around line 121-122: Update the `@ApiResponses` annotation on the relevant
LoadFlowController endpoint so the 200 response description refers to loadflow
modifications rather than computation infos, while leaving the 404 description
unchanged.
- Around line 74-79: Update the catch block in the LoadFlowController flow to
wrap studyService.deleteLoadflowResult in its own try-catch when
loadflowResultUuid is non-null; if rollback fails, attach that rollback
exception to the original exception e using addSuppressed, then rethrow e
unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 8ea4ec95-dc04-4430-b7bd-d94739e4d4ce
📒 Files selected for processing (4)
src/main/java/org/gridsuite/study/server/controller/StudyController.javasrc/main/java/org/gridsuite/study/server/controller/loadflow/LoadFlowController.javasrc/main/java/org/gridsuite/study/server/controller/loadflow/LoadFlowControllerParameters.javasrc/test/java/org/gridsuite/study/server/loadflow/LoadFLowUnitTest.java
💤 Files with no reviewable changes (1)
- src/main/java/org/gridsuite/study/server/controller/StudyController.java
🚧 Files skipped from review as they are similar to previous changes (1)
- src/test/java/org/gridsuite/study/server/loadflow/LoadFLowUnitTest.java
Signed-off-by: basseche <bassel.el-cheikh_externe@rte-france.com>
…Rest Signed-off-by: basseche <bassel.el-cheikh_externe@rte-france.com>
Signed-off-by: basseche <bassel.el-cheikh_externe@rte-france.com>
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/test/java/org/gridsuite/study/server/loadflow/LoadFLowUnitTest.java (1)
99-99: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winCorrect the argument order for
controller.runLoadFlow.The arguments for
rootNetworkUuidandnodeUuidare swapped. Based on the signature ofrunLoadFlowin the newly extractedLoadFlowController,rootNetworkUuidshould precedenodeUuid. Although the test passes because of theany()matchers used in stubbing, this call is functionally incorrect.🐛 Proposed fix
- controller.runLoadFlow(studyUuid, nodeUuid, rootNetworkUuid, false, userId); + controller.runLoadFlow(studyUuid, rootNetworkUuid, nodeUuid, false, userId);🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/test/java/org/gridsuite/study/server/loadflow/LoadFLowUnitTest.java` at line 99, Correct the invocation of LoadFlowController.runLoadFlow in the test by passing rootNetworkUuid before nodeUuid, matching the extracted controller method signature. Keep the remaining arguments and test setup unchanged.
🧹 Nitpick comments (1)
src/test/java/org/gridsuite/study/server/loadflow/LoadFLowUnitTest.java (1)
134-134: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueInclude
loadFlowServicein the reset.Since
loadFlowServicewas added as a@MockitoSpyBean, it's a good practice to include it in theresetcall along withloadFlowServiceRestto avoid state leaking between test executions.♻️ Proposed refactor
- reset(studyService, networkModificationTreeService, networkModificationService, notificationService, loadFlowServiceRest, studyRepository); + reset(studyService, networkModificationTreeService, networkModificationService, notificationService, loadFlowServiceRest, loadFlowService, studyRepository);🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/test/java/org/gridsuite/study/server/loadflow/LoadFLowUnitTest.java` at line 134, Update the test setup reset call in LoadFLowUnitTest to include the loadFlowService MockitoSpyBean alongside loadFlowServiceRest and the other services, ensuring it is reset between test executions.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@src/main/java/org/gridsuite/study/server/service/loadflow/LoadFlowService.java`:
- Around line 39-48: Update getLoadFlowParametersId to use a writable
transaction so mutations made by getLoadFlowParametersOrDefaultsUuid are
persisted through JPA dirty checking. Annotate getLoadFlowProvider with
`@Transactional` and obtain the parameters UUID via
getLoadFlowParametersOrDefaultsUuid(studyEntity) before calling
loadflowServiceRest.getLoadFlowProvider, preserving initialization for
uninitialized studies.
In `@src/main/java/org/gridsuite/study/server/service/StudyService.java`:
- Line 821: The load-flow parameter fetch mutates detached or read-only
StudyEntity instances without persisting initialized UUIDs. Add a transactional
LoadFlowService method accepting the study UUID that initializes and saves
parameters in a short-lived transaction, then replace the studyEntity-based
calls at StudyService.java lines 821, 841, 925, and 3296 with this method,
passing each study UUID.
In `@src/test/java/org/gridsuite/study/server/WorkflowTest.java`:
- Around line 59-60: Change the LoadFlowService field injection in WorkflowTest
from a standard Spring `@Autowired` bean to a Mockito-injected mock, while
preserving Spring test injection so the existing verify() calls operate on that
mock.
---
Outside diff comments:
In `@src/test/java/org/gridsuite/study/server/loadflow/LoadFLowUnitTest.java`:
- Line 99: Correct the invocation of LoadFlowController.runLoadFlow in the test
by passing rootNetworkUuid before nodeUuid, matching the extracted controller
method signature. Keep the remaining arguments and test setup unchanged.
---
Nitpick comments:
In `@src/test/java/org/gridsuite/study/server/loadflow/LoadFLowUnitTest.java`:
- Line 134: Update the test setup reset call in LoadFLowUnitTest to include the
loadFlowService MockitoSpyBean alongside loadFlowServiceRest and the other
services, ensuring it is reset between test executions.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 83161c93-7c17-48b0-a266-ca93006acc42
📒 Files selected for processing (30)
src/main/java/org/gridsuite/study/server/controller/StudyController.javasrc/main/java/org/gridsuite/study/server/controller/loadflow/LoadFlowController.javasrc/main/java/org/gridsuite/study/server/controller/loadflow/LoadFlowControllerParameters.javasrc/main/java/org/gridsuite/study/server/service/ConsumerService.javasrc/main/java/org/gridsuite/study/server/service/RootNetworkNodeInfoService.javasrc/main/java/org/gridsuite/study/server/service/StudyService.javasrc/main/java/org/gridsuite/study/server/service/SupervisionService.javasrc/main/java/org/gridsuite/study/server/service/common/ComputationParametersService.javasrc/main/java/org/gridsuite/study/server/service/loadflow/LoadFlowService.javasrc/main/java/org/gridsuite/study/server/service/loadflow/LoadFlowServiceRest.javasrc/test/java/org/gridsuite/study/server/NetworkAreaDiagramTest.javasrc/test/java/org/gridsuite/study/server/NetworkMapTest.javasrc/test/java/org/gridsuite/study/server/NetworkModificationTest.javasrc/test/java/org/gridsuite/study/server/NetworkModificationTreeTest.javasrc/test/java/org/gridsuite/study/server/SensitivityAnalysisTest.javasrc/test/java/org/gridsuite/study/server/SingleLineDiagramTest.javasrc/test/java/org/gridsuite/study/server/SingleLineDiagramWiremockTest.javasrc/test/java/org/gridsuite/study/server/StudyControllerDynamicMarginCalculationTest.javasrc/test/java/org/gridsuite/study/server/StudyControllerDynamicSecurityAnalysisTest.javasrc/test/java/org/gridsuite/study/server/StudyControllerDynamicSimulationTest.javasrc/test/java/org/gridsuite/study/server/VoltageInitTest.javasrc/test/java/org/gridsuite/study/server/WorkflowTest.javasrc/test/java/org/gridsuite/study/server/loadflow/LoadFLowIntegrationTest.javasrc/test/java/org/gridsuite/study/server/loadflow/LoadFLowUnitTest.javasrc/test/java/org/gridsuite/study/server/loadflow/LoadFlowTest.javasrc/test/java/org/gridsuite/study/server/rootnetworks/RootNetworkControllerTest.javasrc/test/java/org/gridsuite/study/server/rootnetworks/RootNetworkTest.javasrc/test/java/org/gridsuite/study/server/rootnetworks/SecurityAnalysisTest.javasrc/test/java/org/gridsuite/study/server/studycontroller/StudyControllerCreationTest.javasrc/test/java/org/gridsuite/study/server/studycontroller/StudyTestBase.java
💤 Files with no reviewable changes (1)
- src/main/java/org/gridsuite/study/server/controller/StudyController.java
🚧 Files skipped from review as they are similar to previous changes (1)
- src/main/java/org/gridsuite/study/server/controller/loadflow/LoadFlowController.java
| UUID nodeUuidToSearchIn = getNodeUuidToSearchIn(nodeUuid, rootNetworkUuid, inUpstreamBuiltParentNode); | ||
| StudyEntity studyEntity = getStudy(studyUuid); | ||
| LoadFlowParameters loadFlowParameters = getLoadFlowParameters(studyEntity); | ||
| LoadFlowParameters loadFlowParameters = loadFlowService.getLoadFlowParameters(studyEntity); |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🔴 Critical | 🏗️ Heavy lift
Lost update hazard: mutated detached entity is not saved.
All these sites pass a detached or read-only studyEntity to loadFlowService.getLoadFlowParameters(studyEntity). The shared root cause is that if the parameters UUID is uninitialized, the underlying REST client creates new default parameters remotely and mutates the studyEntity. Because these map-data operations lack a read-write transaction (and holding a DB transaction open over remote map calls is an anti-pattern), the mutated UUID is never saved to the database. This leads to orphaned remote parameters created on every request.
Consider exposing a @Transactional getLoadFlowParameters(UUID studyUuid) in LoadFlowService that safely initializes and saves the parameters in a short-lived transaction, and calling that here instead.
src/main/java/org/gridsuite/study/server/service/StudyService.java#L821-L821: Delegate to a transaction-safe parameters fetch instead of passing the detached entity.src/main/java/org/gridsuite/study/server/service/StudyService.java#L841-L841: Delegate to a transaction-safe parameters fetch instead of passing the detached entity.src/main/java/org/gridsuite/study/server/service/StudyService.java#L925-L925: Delegate to a transaction-safe parameters fetch instead of passing the detached entity.src/main/java/org/gridsuite/study/server/service/StudyService.java#L3296-L3296: Delegate to a transaction-safe parameters fetch instead of passing the read-only entity.
📍 Affects 1 file
src/main/java/org/gridsuite/study/server/service/StudyService.java#L821-L821(this comment)src/main/java/org/gridsuite/study/server/service/StudyService.java#L841-L841src/main/java/org/gridsuite/study/server/service/StudyService.java#L925-L925src/main/java/org/gridsuite/study/server/service/StudyService.java#L3296-L3296
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/main/java/org/gridsuite/study/server/service/StudyService.java` at line
821, The load-flow parameter fetch mutates detached or read-only StudyEntity
instances without persisting initialized UUIDs. Add a transactional
LoadFlowService method accepting the study UUID that initializes and saves
parameters in a short-lived transaction, then replace the studyEntity-based
calls at StudyService.java lines 821, 841, 925, and 3296 with this method,
passing each study UUID.
Signed-off-by: basseche <bassel.el-cheikh_externe@rte-france.com>
Signed-off-by: basseche <bassel.el-cheikh_externe@rte-france.com>
Signed-off-by: basseche <bassel.el-cheikh_externe@rte-france.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
For each model :