Skip to content

[3.x] Remove macros from InMemoryPage#2550

Merged
emmadesilva merged 5 commits into
v3/redesign-in-memory-pagesfrom
v3/redesign-in-memory-pages-remove-macros
Jul 15, 2026
Merged

[3.x] Remove macros from InMemoryPage#2550
emmadesilva merged 5 commits into
v3/redesign-in-memory-pagesfrom
v3/redesign-in-memory-pages-remove-macros

Conversation

@emmadesilva

@emmadesilva emmadesilva commented Jul 15, 2026

Copy link
Copy Markdown
Member

After #2548 I don't see the need for this any more. It's better to instead simply extend the class if needed. We do lose out on the internal typeLabel macro but it's not documented so I do not consider it part of BC. And we can instead set a good example by extracting thin wrapper classes.

@codecov

codecov Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (17f8ead) to head (dd98e88).

Additional details and impacted files
@@                       Coverage Diff                       @@
##             v3/redesign-in-memory-pages     #2550   +/-   ##
===============================================================
  Coverage                         100.00%   100.00%           
+ Complexity                          1744      1713   -31     
===============================================================
  Files                                179       175    -4     
  Lines                               4370      4295   -75     
===============================================================
- Hits                                4370      4295   -75     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@emmadesilva emmadesilva merged commit 54e9863 into v3/redesign-in-memory-pages Jul 15, 2026
7 checks passed
@emmadesilva emmadesilva deleted the v3/redesign-in-memory-pages-remove-macros branch July 15, 2026 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant