V3#16
Merged
Merged
Conversation
- package.json: type=module, exports map, engines node>=22.12, @imqueue/core ^3.2.0 (the ESM core) - explicit .js extensions on all relative imports - tsconfig: es2024, skipLibCheck, verbatimModuleSyntax with import type annotations throughout - helpers/env pkg(): reads the consumer package.json with readFileSync/JSON.parse instead of require() (no module semantics needed for JSON) - helpers/transport: winston transport option types imported type-only from the explicit index.js subpath (ESM has no directory resolution; type-only imports are erased so no runtime deep-require remains) - tests: fresh package manifest read via import.meta.url BREAKING CHANGE: package is ESM-only; CJS consumers require Node >=22.12 (require(esm)) and TypeScript >=5.8 to type-check Verified: 31/31 on Node 24.16.0 and docker node:24 (24.18.0); CJS require(esm) interop smoke-tested (default instance, Logger, helpers)
The only things imported from core were the ILogger and JsonObject types. They are now structural copies in src/types.ts (re-exported from the package root), so the logger carries no runtime dependency on the queue library while values typed against it stay assignment-compatible with code written for the core interfaces. Runtime dependencies are now winston and winston-transport only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.