V3#30
Merged
Merged
Conversation
Two independent issues broke the suite after bumping @imqueue/core to
^3.2.0 (now an ES module consumed from CJS via require(esm)):
1. The ioredis mock registered only a default export; core's ESM sources
bind the named { Redis } import, so linking failed with 'does not
provide an export named Redis'. The mock now registers both shapes.
2. node:test module mocks evaluate asynchronously, and the synchronous
require(esm) path cannot wait for them — the mocked graph loads with
export names present but values unbound (core_1.Redis undefined). The
new test/warmup.mjs preload (wired via --import) registers the mocks
and fully awaits the @imqueue/core graph before any spec runs, so CJS
specs then require() the cached, bound namespace.
Also switches moduleMockOptions to the documented defaultExport /
namedExports pair with cache:false — the undocumented exports option and
cache:true value binding both broke on the Node 24.17/24.18 loader
changes (same fix as imqueue/core@5137ffa).
Verified: 197/197 on Node 24.16.0 and in docker node:24 (24.18.0);
includes the @imqueue/core ^3.2.0 dependency bump the fixes target.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.