Remove Series class in favor of single-column DataFrame#38
Conversation
- Deleted `leanframe/core/series.py`. - Updated `DataFrame.__getitem__` to return a single-column `DataFrame` instead of `Series`. - Created mixin classes (`AggregationsMixin`, `TransformationsMixin`, `ArithmeticMixin`, `ComparisonsMixin`) for `DataFrame` to support column-wise operations that were previously available on `Series`. - Adjusted type annotations and `__init__` files to avoid circular imports. - Re-wrote `assign` logic in `DataFrame` to handle single-column dataframe inputs properly avoiding `IntegrityError` from overlapping Ibis relations. - Migrated tests. Co-authored-by: tswast <247555+tswast@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Deleted `leanframe/core/series.py`. - Updated `DataFrame.__getitem__` to return a single-column `DataFrame` instead of `Series`. - Created mixin classes (`AggregationsMixin`, `TransformationsMixin`, `ArithmeticMixin`, `ComparisonsMixin`) for `DataFrame` to support column-wise operations that were previously available on `Series`. - Adjusted type annotations and `__init__` files to avoid circular imports. - Re-wrote `assign` logic in `DataFrame` to handle single-column dataframe inputs properly avoiding `IntegrityError` from overlapping Ibis relations. - Migrated tests. Co-authored-by: tswast <247555+tswast@users.noreply.github.com>
1 participant
Removed the deprecated
Seriesclass and replaced its logic by using single-columnDataFrameoperations. This includes adding several mixins to keep theDataFrameclass small.PR created automatically by Jules for task 17348872327282844394 started by @tswast