[top-i2c,dv] Made host_tx_rx_test randomized#634
Merged
Conversation
KinzaQamar
requested review from
elliotb-lowrisc,
engdoreis,
marnovandermaas and
ziuziakowska
and removed request for
elliotb-lowrisc and
ziuziakowska
June 22, 2026 16:40
KinzaQamar
force-pushed
the
i2c_host_test_modif
branch
from
June 22, 2026 16:42
1385548 to
7c06242
Compare
KinzaQamar
force-pushed
the
i2c_host_test_modif
branch
from
June 22, 2026 16:47
7c06242 to
babdfc5
Compare
elliotb-lowrisc
approved these changes
Jun 23, 2026
elliotb-lowrisc
left a comment
elliotb-lowrisc
left a comment
Contributor
There was a problem hiding this comment.
Seems good to me, assuming that it has been tested. Just one minor typo
KinzaQamar
force-pushed
the
i2c_host_test_modif
branch
2 times, most recently
from
June 23, 2026 10:46
b05f671 to
b0c08dd
Compare
martin-velay
reviewed
Jul 7, 2026
martin-velay
changed the title
Signed-off-by: Kinza Qamar <kqzaman@lowrisc.org>
Signed-off-by: Kinza Qamar <kqzaman@lowrisc.org>
KinzaQamar
force-pushed
the
i2c_host_test_modif
branch
from
July 17, 2026 11:33
b0c08dd to
f32f188
Compare
martin-velay
approved these changes
Jul 17, 2026
martin-velay
left a comment
martin-velay
left a comment
Contributor
There was a problem hiding this comment.
Thanks Kinza. It looks good.
I also ran the simulations for the related tests:
| Stage | Name | Tests | Max Job Runtime | Simulated Time | Passing | Total | Pass Rate |
|:-------:|:------:|:---------------------|:-----------------:|:----------------:|:---------:|:-------:|:-----------:|
| | | i2c_host_tx_rx | 24.000s | 1676.118us | 1 | 1 | 100.00 % |
| | | i2c_host_tx_rx_cheri | 148.000s | 13226.515us | 1 | 1 | 100.00 % |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now it can read / write multiple bytes on any 7-bit address