Raise StreamDisconnectedError on SSE error frames#596
Open
mistralai-nfau wants to merge 7 commits into
Open
Conversation
Adds an AfterSuccess hook that converts a workflow SSE `event: error` frame into a raised StreamDisconnectedError (reason + error), so consumers use try/except around stream iteration instead of inspecting each event.
anth2o
approved these changes
Jul 22, 2026
anth2o
left a comment
anth2o
left a comment
Contributor
There was a problem hiding this comment.
Mostly nit suggestions and test case additions, otherwise LGTM
…s streams - Move WorkflowStreamErrorHook to client/_hooks alongside the other hooks - Cover deployment + execution logs SSE streams (same error-frame contract) - Derive valid reasons from the StreamDisconnectReason Literal - Add tests: error frame without trailing boundary; all stream operations
- Error hook forwards the raw stream unchanged, so it must keep Content-Encoding (httpx decodes downstream); removes duplication with workflow_encoding_hook - Add test that the encoding hook + stream error hook compose correctly
Use json.loads(strict=False) so a value spanning several data: lines (rejoined with a literal newline per the SSE spec) still yields reason/error instead of silently falling back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an
AfterSuccesshook that turns a workflow SSEevent: errorframe into a raisedStreamDisconnectedError(withreason+error), so consumers can wrap stream iteration intry/exceptinstead of inspecting every event.Import:
from mistralai.extra.exceptions import StreamDisconnectedErrorRefs WFL-1679.