Improve type checks#14036
Open
larsoner wants to merge 20 commits into
Open
Conversation
* upstream/main: Fix transition bandwidth reported in 'filter too short' error (mne-tools#11406) (mne-tools#14005)
Member
Author
|
Okay too many packages needed for type checking made |
Member
Author
|
A tiny bit of stuff here would get simpler if we dropped 3.10 support. 3.11 is actually almost out of SPEC0 so I don't mind dropping 3.10 now. But not too painful to keep it. It's EOL in October. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mypytoty, including as pre-commit astyis fast enough 🚀docstubbut let's use it here for a bit)mypymissed some stuff) and checking inepochs.py,evoked.py, andmne/ioio.read_raw_*, but keep theirdocs// website aliases pointing to publicly documented objectsdict[str, Any], 2)assert x is not Nonefor whenxisself._dataetc. (places where we know it is by code structure), plus using__getattr__and__setattr__to get*Bunchclasses to play nicelyctf/res4.pybecause type checkers have trouble with NumPy structured arraysinstance of RawEDFwhere we should have hadinstance of RawBDFUsed Claude Opus 4.8 to help me with the drudgery of
assert x is not Noneetc., but I also made a lot of changes myself, and understand + vouch for all code.