Add a keyboard shortcut (⌘⇧E) to open the composer's thinking menu#55
Open
DragonnZhang wants to merge 3 commits into
Open
Add a keyboard shortcut (⌘⇧E) to open the composer's thinking menu#55DragonnZhang wants to merge 3 commits into
DragonnZhang wants to merge 3 commits into
Conversation
The composer's thinking-level (reasoning effort) picker could only be opened with the mouse. Add a chat.openThinkingMenu action bound to mod+shift+e that opens it from the keyboard, matching Claude Code Desktop's effort-menu shortcut. The action registry lives at the app shell while the dropdown's open state lives in FreeFormInput, so the shortcut is bridged with a scoped craft:open-composer-menu event, mirroring the existing craft:focus-input pattern (shouldHandleScopedInputEvent) so multi-panel layouts target the focused composer. The action auto-appears in the Command Palette and the Keyboard Shortcuts reference. One new i18n key across all locales. Closes #54
Resolve merge conflict in docs/loop/feature-ledger.md (append-only ledger) by keeping the branch's reconciled superset, which already includes the reduce-motion (#51) row. Locale files auto-merged cleanly; i18n parity verified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #54
What & why
OpenWork's composer toolbar has a model picker, a thinking-level (reasoning
effort) picker (#45), and a permission-mode selector. Two of those already
have keyboard access — permission mode cycles with
Shift+Tab— but thethinking-level menu could only be opened with the mouse.
Claude Code Desktop documents a dedicated effort-menu shortcut (
⌘⇧E) in itscomposer. When the thinking picker landed here, #44 explicitly flagged the
shortcut as a natural follow-up ("A keyboard-only shortcut (à la
⌘⇧E) could opena menu … can be layered on later"). This layers it on.
Press
⌘⇧E(macOS) /Ctrl+Shift+E(Windows/Linux) to open thecomposer's thinking-effort menu from anywhere — matching Claude Code Desktop's
effort-menu shortcut exactly.
Changes
actions/definitions.ts— newchat.openThinkingMenuaction (hotkeymod+shift+e, category Chat).actions/action-i18n.ts— maps it toshortcuts.action.openThinkingMenu.components/app-shell/input/composer-menu-events.ts(new) — a small,scoped
craft:open-composer-menuevent, modeled onfocus-input-events.ts.AppShell.tsx— registers the action; it dispatches the scoped event tothe focused composer.
components/app-shell/input/FreeFormInput.tsx— listens for the event(guarded by
shouldHandleScopedInputEvent, the same multi-panel routing usedby
craft:focus-input) and opens its already-controlledthinkingDropdownOpendropdown. No-ops in compact mode / when the picker is unavailable.
packages/shared/src/i18n/locales/*.json— one new key(
shortcuts.action.openThinkingMenu) in all 7 locales, in sorted position.e2e/assertions/thinking-menu-shortcut.assert.ts(new) — CDP assertion(below).
Because it registers in the action registry, the shortcut automatically
appears in the Command Palette (#42) and the Keyboard Shortcuts reference — no
extra wiring. Frontend-only: no backend / qwen-code change.
Why
⌘⇧Eand not also⌘⇧I/⌘⇧MClaude binds all three composer menus, but in OpenWork
⌘⇧I/Ctrl+Shift+Iisalready Developer Tools, and permission mode already has
Shift+Tab. Thethinking menu is the one composer picker with no keyboard access and no
binding conflict, so this PR scopes to the clean
⌘⇧Egap.Verification (DoD)
bun run typecheck:all— zero new errors. The only errors are the 11pre-existing ones in
apps/electron(auto-update.tsowner/repo, asettings-default-thinkingtest tuple, two test files importingvitest) —none in the files this PR touches.
packages/{core,shared,server-core,server,session-tools-core,ui}all pass clean.
bun test— the failing set is byte-for-byte identical tomain,verified by diffing the sorted unique failure lists from a clean-
mainrun andthis branch in the same environment: 56 pre-existing failures on both,
zero new failures. The touched-area suites (
renderer/actions,app-shell/input) pass 23/23.bun run lint:i18n:parity— OK (6 locales, 1543 keys each).bun run electron:build:renderer, where this change lives)— ✅ builds cleanly.
bun build e2e/assertions/thinking-menu-shortcut.assert.ts)— ✅.
CDP e2e assertion (
thinking-menu-shortcut.assert.ts)Drives the real built app over CDP entirely in the draft (no-session) state — no
seeded conversation and no backend:
visible menu items).
Cmd/Ctrl+Shift+Ekeydown at the window level (where the actionregistry's capture-phase listener lives).
Asserting the menu is closed before the keypress and open after it proves the
shortcut actually opens the menu, not merely that the menu can render.
Part of the autonomous desktop-feature loop (
loop-bot).🤖 Generated with Claude Code
Generated by Claude Code