Skip to content

Support for custom LC UC words min %#43

Merged
mmathieum merged 1 commit into
masterfrom
mm/custom_LC_pct
Jul 3, 2026
Merged

Support for custom LC UC words min %#43
mmathieum merged 1 commit into
masterfrom
mm/custom_LC_pct

Conversation

@mmathieum

Copy link
Copy Markdown
Member

No description provided.

@mmathieum mmathieum self-assigned this Jul 3, 2026
@mmathieum mmathieum marked this pull request as ready for review July 3, 2026 00:06

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a configurable minimum uppercase percentage threshold (lowerUCWordsMinPct) when converting uppercase words to lowercase. The changes overload toLowerCaseUpperCaseWords in CleanUtils.java and add an optional parameter across several methods in StringsCleaner.kt. The review feedback recommends using a non-nullable Float with CleanUtils.DEFAULT_MIN_UPPER_CASE_PCT as the default value in Kotlin instead of a nullable Float? defaulting to null. This avoids unnecessary autoboxing overhead and simplifies the code by eliminating the need for Elvis operators downstream.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/main/java/org/mtransit/commons/StringsCleaner.kt
Comment thread src/main/java/org/mtransit/commons/StringsCleaner.kt
Comment thread src/main/java/org/mtransit/commons/StringsCleaner.kt
Comment thread src/main/java/org/mtransit/commons/StringsCleaner.kt
Comment thread src/main/java/org/mtransit/commons/StringsCleaner.kt
@mmathieum mmathieum merged commit 2acf0b3 into master Jul 3, 2026
7 of 8 checks passed
@mmathieum mmathieum deleted the mm/custom_LC_pct branch July 3, 2026 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant