Fix for delays on ESP32 & ESP8266#271
Merged
Merged
Conversation
- Getting WDT resets on ESP8266 with RF24Ethernet + lwIP while using WiFi and OTA sketch - this should address that issue
Contributor
There was a problem hiding this comment.
Cpp-linter Review
Used clang-format v14.0.6
Click here for the full clang-format patch
diff --git a/RF24Network.cpp b/RF24Network.cpp
index 61faff7..4b310a9 100644
--- a/RF24Network.cpp
+++ b/RF24Network.cpp
@@ -1318,2 +1318,2 @@ bool ESBNetwork<radio_t>::sleepNode(unsigned int cycles, int interruptPin, uint8
- } // The WDT_vect interrupt wakes the MCU from here
- sleep_disable(); // System continues execution here when watchdog timed out
+ } // The WDT_vect interrupt wakes the MCU from here
+ sleep_disable(); // System continues execution here when watchdog timed out
diff --git a/RF24Network.h b/RF24Network.h
index b76356c..a267ec2 100644
--- a/RF24Network.h
+++ b/RF24Network.h
@@ -976 +976 @@ private:
- uint8_t frame_queue[1]; /** Space for a small set of frames that need to be delivered to the app layer */
+ uint8_t frame_queue[1]; /** Space for a small set of frames that need to be delivered to the app layer */
@@ -981 +981 @@ private:
- uint8_t* next_frame; /** Pointer into the @p frame_queue where we should place the next received frame */
+ uint8_t* next_frame; /** Pointer into the @p frame_queue where we should place the next received frame */
Have any feedback or feature suggestions? Share it here.
Contributor
There was a problem hiding this comment.
Cpp-linter Review
Used clang-format v14.0.6
Click here for the full clang-format patch
diff --git a/RF24Network.cpp b/RF24Network.cpp
index 61faff7..4b310a9 100644
--- a/RF24Network.cpp
+++ b/RF24Network.cpp
@@ -1318,2 +1318,2 @@ bool ESBNetwork<radio_t>::sleepNode(unsigned int cycles, int interruptPin, uint8
- } // The WDT_vect interrupt wakes the MCU from here
- sleep_disable(); // System continues execution here when watchdog timed out
+ } // The WDT_vect interrupt wakes the MCU from here
+ sleep_disable(); // System continues execution here when watchdog timed out
diff --git a/RF24Network.h b/RF24Network.h
index b900851..7ca76c9 100644
--- a/RF24Network.h
+++ b/RF24Network.h
@@ -974 +974 @@ private:
- uint8_t frame_queue[1]; /** Space for a small set of frames that need to be delivered to the app layer */
+ uint8_t frame_queue[1]; /** Space for a small set of frames that need to be delivered to the app layer */
@@ -979 +979 @@ private:
- uint8_t* next_frame; /** Pointer into the @p frame_queue where we should place the next received frame */
+ uint8_t* next_frame; /** Pointer into the @p frame_queue where we should place the next received frame */
Have any feedback or feature suggestions? Share it here.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Cpp-linter Review
Used clang-format v14.0.6
Click here for the full clang-format patch
diff --git a/RF24Network.h b/RF24Network.h
index b900851..5da9947 100644
--- a/RF24Network.h
+++ b/RF24Network.h
@@ -979 +979 @@ private:
- uint8_t* next_frame; /** Pointer into the @p frame_queue where we should place the next received frame */
+ uint8_t* next_frame; /** Pointer into the @p frame_queue where we should place the next received frame */
Have any feedback or feature suggestions? Share it here.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2bndy5
approved these changes
Jun 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #267 , this should address that issue, but leaving issue open to monitor.