Skip to content

Fix for delays on ESP32 & ESP8266#271

Merged
TMRh20 merged 7 commits into
masterfrom
FixForDelays
Jun 7, 2026
Merged

Fix for delays on ESP32 & ESP8266#271
TMRh20 merged 7 commits into
masterfrom
FixForDelays

Conversation

@TMRh20

@TMRh20 TMRh20 commented Jun 7, 2026

Copy link
Copy Markdown
Member
  • Getting WDT resets on ESP8266 with RF24Ethernet + lwIP while using WiFi and OTA sketch - this should address that issue

See #267 , this should address that issue, but leaving issue open to monitor.

- Getting WDT resets on ESP8266 with RF24Ethernet + lwIP while using WiFi and OTA sketch - this should address that issue

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cpp-linter Review

Used clang-format v14.0.6

Click here for the full clang-format patch
diff --git a/RF24Network.cpp b/RF24Network.cpp
index 61faff7..4b310a9 100644
--- a/RF24Network.cpp
+++ b/RF24Network.cpp
@@ -1318,2 +1318,2 @@ bool ESBNetwork<radio_t>::sleepNode(unsigned int cycles, int interruptPin, uint8
-    } // The WDT_vect interrupt wakes the MCU from here
-    sleep_disable(); // System continues execution here when watchdog timed out
+    }                 // The WDT_vect interrupt wakes the MCU from here
+    sleep_disable();  // System continues execution here when watchdog timed out
diff --git a/RF24Network.h b/RF24Network.h
index b76356c..a267ec2 100644
--- a/RF24Network.h
+++ b/RF24Network.h
@@ -976 +976 @@ private:
-    uint8_t frame_queue[1]; /** Space for a small set of frames that need to be delivered to the app layer */
+    uint8_t frame_queue[1];  /** Space for a small set of frames that need to be delivered to the app layer */
@@ -981 +981 @@ private:
-    uint8_t* next_frame; /** Pointer into the @p frame_queue where we should place the next received frame */
+    uint8_t* next_frame;                                 /** Pointer into the @p frame_queue where we should place the next received frame */

Have any feedback or feature suggestions? Share it here.

Comment thread RF24Network.cpp Outdated
Comment thread RF24Network.h Outdated
Comment thread RF24Network.h Outdated
@github-actions
github-actions Bot dismissed their stale review June 7, 2026 13:02

outdated suggestion

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cpp-linter Review

Used clang-format v14.0.6

Click here for the full clang-format patch
diff --git a/RF24Network.cpp b/RF24Network.cpp
index 61faff7..4b310a9 100644
--- a/RF24Network.cpp
+++ b/RF24Network.cpp
@@ -1318,2 +1318,2 @@ bool ESBNetwork<radio_t>::sleepNode(unsigned int cycles, int interruptPin, uint8
-    } // The WDT_vect interrupt wakes the MCU from here
-    sleep_disable(); // System continues execution here when watchdog timed out
+    }                 // The WDT_vect interrupt wakes the MCU from here
+    sleep_disable();  // System continues execution here when watchdog timed out
diff --git a/RF24Network.h b/RF24Network.h
index b900851..7ca76c9 100644
--- a/RF24Network.h
+++ b/RF24Network.h
@@ -974 +974 @@ private:
-    uint8_t frame_queue[1]; /** Space for a small set of frames that need to be delivered to the app layer */
+    uint8_t frame_queue[1];  /** Space for a small set of frames that need to be delivered to the app layer */
@@ -979 +979 @@ private:
-    uint8_t* next_frame; /** Pointer into the @p frame_queue where we should place the next received frame */
+    uint8_t* next_frame;                                 /** Pointer into the @p frame_queue where we should place the next received frame */

Have any feedback or feature suggestions? Share it here.

Comment thread RF24Network.cpp Outdated
Comment thread RF24Network.h Outdated
Comment thread RF24Network.h Outdated
TMRh20 and others added 2 commits June 7, 2026 07:03
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions
github-actions Bot dismissed their stale review June 7, 2026 13:03

outdated suggestion

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cpp-linter Review

Used clang-format v14.0.6

Click here for the full clang-format patch
diff --git a/RF24Network.h b/RF24Network.h
index b900851..5da9947 100644
--- a/RF24Network.h
+++ b/RF24Network.h
@@ -979 +979 @@ private:
-    uint8_t* next_frame; /** Pointer into the @p frame_queue where we should place the next received frame */
+    uint8_t* next_frame;                                 /** Pointer into the @p frame_queue where we should place the next received frame */

Have any feedback or feature suggestions? Share it here.

Comment thread RF24Network.h Outdated
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions
github-actions Bot dismissed their stale review June 7, 2026 13:04

outdated suggestion

@TMRh20
TMRh20 requested a review from 2bndy5 June 7, 2026 13:17
@TMRh20
TMRh20 merged commit e52709f into master Jun 7, 2026
25 checks passed
@TMRh20
TMRh20 deleted the FixForDelays branch June 7, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants