Skip to content

Fix legacy TileId coordinate conversion#179

Open
josephbirkner wants to merge 1 commit into
mainfrom
bugfix/legacy-tileid-y-axis
Open

Fix legacy TileId coordinate conversion#179
josephbirkner wants to merge 1 commit into
mainfrom
bugfix/legacy-tileid-y-axis

Conversation

@josephbirkner

Copy link
Copy Markdown
Contributor

Summary

  • convert both legacy mapget tile-grid axes into PackedTileId's signed NDS Morton coordinate order
  • cover a known legacy Germany tile in the model and MapTileKey tests
  • verify legacy GeoJSONFolder manifest and filename ingestion resolve to the correct packed tile

Root cause

legacyTileIdToPacked passed the legacy X/Y grid coordinates directly to PackedTileId::fromTileXY. The legacy grid starts at the antimeridian and north pole, while PackedTileId grid coordinates are derived from signed NDS coordinates in two's-complement Morton order. The resulting tiles therefore landed in the wrong geographic region.

Validation

  • cmake --build build --target test.mapget -- -j8
  • focused TileId, MapTileKey, and GeoJsonSource tests
  • full 105-test suite; the two Python integration tests were rerun serially because parallel local ndslive-math wheel builds share a build directory

@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown
Package Line Rate Branch Rate Health
libs.geojsonsource.include.geojsonsource 100% 50% βœ”
libs.geojsonsource.src 66% 38% βž–
libs.gridsource.include.gridsource 0% 0% ❌
libs.gridsource.src 0% 0% ❌
libs.http-datasource.src 48% 26% ❌
libs.http-service.src 58% 24% βž–
libs.location.include.mapget.location 100% 100% βœ”
libs.location.src 83% 40% βœ”
libs.logging.include.mapget 5% 2% ❌
libs.model.include.mapget.model 51% 30% βž–
libs.model.src 73% 42% βž–
libs.service.include.mapget.service 56% 50% βž–
libs.service.src 74% 38% βž–
Summary 65% (12147 / 18562) 35% (12928 / 37286) βž–

Minimum allowed line rate is 50%

@josephbirkner
josephbirkner marked this pull request as ready for review July 16, 2026 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant