chore(release): bump version to 1.20.0#74
Merged
Conversation
ErickXavier
commented
Jul 17, 2026
ErickXavier
left a comment
Collaborator
Author
There was a problem hiding this comment.
APPROVED — QA GATE (T8, EPIC NOJS-270)
Scope verified: version bump 1.19.0 → 1.20.0 only. HELD note present in PR body (do not merge until v1.20.0 release, T10).
Evidence
package.json:3at 1.20.0; only other changes are the version banner line in dist/cjs, dist/esm, dist/iife — no stray changes.- Fresh rebuild (
npm run build, all 3 formats) →git statusclean on dist/, committed output byte-identical. npm test(with Core sibling checkout present, as the suite requires): 20 suites passed, 498 passed / 5 skipped — matches PR body exactly.- Code review (multi-angle): no correctness findings; banner is generated from
pkg.versionin build.js, no hardcoded versions in src/tests, README badge is dynamic. - Commit
5cac90bconventional, author/committer Erick Xavier, no trailers, no AI attribution in commit or PR body. - Ecosystem parity confirmed: nojs#290, nojs-lsp#81, nojs-skill#70 all at 1.20.0.
Non-blocking notes
- CHANGELOG has no [1.20.0] entry — expected, deferred to T9.
package-lock.jsonroot version stale at 1.16.1 (pre-existing; LSP's PR bumped its lock — consider aligning here in T9/release).
Collaborator
Author
|
Appended changelog commit (0390176): |
ErickXavier
commented
Jul 17, 2026
ErickXavier
left a comment
Collaborator
Author
There was a problem hiding this comment.
APPROVED — QA GATE (T9 / NOJS-279)
Verified:
- CHANGELOG [1.20.0] entry matches the house style of the [1.19.0]/[1.18.0]/[1.17.0] compatibility entries verbatim (heading
## [1.20.0](compare) — 2026-07-17,### Changed, single alignment bullet);[Unreleased]link advanced tov1.20.0...HEAD. - "No functional changes to elements" claim verified: the two commits touch only CHANGELOG.md, package.json, package-lock.json, and the three dist banners (exactly 1 line each,
v1.19.0 → v1.20.0, consistent with a clean rebuild of unchanged src — banner derives frompkg.versionin build.js). - package-lock.json diff limited to the two root version fields (1.16.1 → 1.20.0); this also fixes pre-existing lock drift (the 1.19.0 release never updated the lockfile).
- Both commits conventional (
chore/docsscopes), authored by Erick Xavier, no AI attribution trailers. - /code-review pipeline (8 finder angles across 3 batches): zero findings.
No blocking issues. Ready to merge at T10.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Evidence
npm run buildsucceeded — all 3 formats (IIFE, ESM, CJS) outputStatus
HELD — do not merge until v1.20.0 release (T10)