doc: clarify rules for adding new built-in modules#64648
Open
aduh95 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Collaborator
|
Review requested:
|
panva
approved these changes
Jul 21, 2026
targos
approved these changes
Jul 21, 2026
UlisesGascon
approved these changes
Jul 21, 2026
aduh95
added
author ready
cjihrig
approved these changes
Jul 21, 2026
marco-ippolito
approved these changes
Jul 21, 2026
lpinca
approved these changes
Jul 21, 2026
|
|
||
| When adding promises to an existing API, add `/promises` | ||
| (`inspector/promises`, etc.). Apply the `semver-major` label to the addition. | ||
| When adding a "sub-module", e.g. a promise varient of an existing API (e.g. |
Member
There was a problem hiding this comment.
Suggested change
| When adding a "sub-module", e.g. a promise varient of an existing API (e.g. | |
| When adding a "sub-module", e.g. a promise variant of an existing API (e.g. |
jasnell
approved these changes
Jul 21, 2026
Member
|
And I'm +1 on retroactively changing the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've added thePRs that contain breaking changes and should be released in the next major version.
, but I'd argue that it doesn't make sense to treat as semver-major a new
node:prefix requirement to avoid the semver-major requirement for new modules (well I don't remember if it was the intent, but it's definitely the consequence of it). In #62066 (comment), @jasnell marked the PR introducingnode:stream/iteras semver-majorprefixedmodule(i.e. it cannot shadow a user package)that's behind a runtime flag anyways. EDIT: it's not actually prefix-only,require('stream/iter') === require(node:stream/iter')– but still, because it's opt-in I think my point still stands.In the case of
node:stream/iter, not backporting it is blocking a number of backports on Node.js 24, which cascades into creating more conflicts on unrelated backports, which is a big maintenance burden