Skip to content

Fix ci check examples#706

Open
martintomazic wants to merge 1 commit into
masterfrom
martin/fix-ci-check-examples
Open

Fix ci check examples#706
martintomazic wants to merge 1 commit into
masterfrom
martin/fix-ci-check-examples

Conversation

@martintomazic

Copy link
Copy Markdown
Contributor

Fixes existing CI issue:

run make-examples

....

Running network-show/id-entity.in:
  /Users/runner/work/cli/cli/oasis network show xQN6ffLSdc51EfEQ2BzltK1iWYAw6Y1CkBAbFzlhhEQ= --config /tmp/cli_examples/network-show/cli.toml 
Error: could not get a node: registry: no such node
make: *** [examples/network-show/id-entity.out] Error 1
Error: Process completed with exit code 2.

E.g. see https://github.com/oasisprotocol/cli/actions/runs/28896146091/job/85721038314?pr=705

@netlify

netlify Bot commented Jul 8, 2026

Copy link
Copy Markdown

Deploy Preview for oasisprotocol-cli canceled.

Name Link
🔨 Latest commit ba5d76d
🔍 Latest deploy log https://app.netlify.com/projects/oasisprotocol-cli/deploys/6a4e84c6b2042f000857594b

@martintomazic martintomazic requested review from matevz and peternose July 8, 2026 14:11
@martintomazic martintomazic marked this pull request as ready for review July 8, 2026 14:11

@peternose peternose left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is not the right solution for the mentioned CI problem. You should investigate why the test fails and fix it, instead of changing the function.

Comment thread cmd/network/show.go Outdated
Comment thread cmd/network/show.go Outdated
Comment thread examples/network-show/id-entity.in
@martintomazic martintomazic force-pushed the martin/fix-ci-check-examples branch from 3fb9117 to ba5d76d Compare July 8, 2026 17:11
@martintomazic martintomazic requested review from matevz and peternose July 8, 2026 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants