feat(nlp): raise K2 Full draft instruction coverage (39→145)#184
Open
oldrepublicwizard wants to merge 1 commit into
Open
feat(nlp): raise K2 Full draft instruction coverage (39→145)#184oldrepublicwizard wants to merge 1 commit into
oldrepublicwizard wants to merge 1 commit into
Conversation
Parse common K2 guide phrases (Override/movies moves, HoloPatcher, quoted options, .tpc variants) and fall back to InstallationMethod when prose alone yields no drafts so convert --parse-directions covers the full K2 Full component set for review.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This was referenced Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NaturalLanguageInstructionParserfor common K2 Full / neocities phrases: Override-folder installs, movies destination, HoloPatcher/TSLPatcher runs, quoted install options,.tpcvariant moves, go-into-folder moves, and cross-sentence overwrite handling.DraftInstructionServicewith sandboxedInstallationMethodfallbacks (Patcher / loose-file Move / Execute) when prose alone yields no drafts, including method-only mods with no Installation Instructions section.Draft coverage (
k2_full_guide.md+--parse-directions)Of the 145 drafted components: 73 from Directions prose (parser), 72 from InstallationMethod-only fallback. All drafts remain flagged for review (never auto-trusted).
Remaining gaps (validate / install next)
Move <<modDirectory>>\*/Patcher <<modDirectory>>need human confirmation of real archive layouts and option namespaces.Test plan
dotnet test --filter FullyQualifiedName~GuideIngestionTests(38 passed, 5 skipped)convert -i src/ModSync.Tests/Fixtures/k2_full_guide.md --parse-directions→Drafted instructions for 145 component(s)mod-buildsK2 archives