fix: changed log level of provider state change transition messages to debug#1987
fix: changed log level of provider state change transition messages to debug#1987jarebudev wants to merge 1 commit into
Conversation
Signed-off-by: jarebudev <23311805+jarebudev@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe log statement in FeatureProviderStateManager's setState method is changed from info level to debug level for provider state transition messages, reducing default log verbosity. ChangesLog Level Change
Estimated code review effort: 1 (Trivial) | ~2 minutes Related issues: Suggested labels: logging, minor Suggested reviewers: N/A Poem: A rabbit hopped through logs so loud, / INFO shouting to the crowd. / Now hushed to debug, soft and neat, / STALE to READY, a quiet feat. 🐰 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1987 +/- ##
============================================
+ Coverage 92.23% 93.21% +0.97%
- Complexity 669 672 +3
============================================
Files 59 59
Lines 1635 1635
Branches 186 186
============================================
+ Hits 1508 1524 +16
+ Misses 80 66 -14
+ Partials 47 45 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| providerName = delegate.getMetadata().getName(); | ||
| } | ||
| log.info("Provider {} transitioned from state {} to state {}", providerName, oldState, state); | ||
| log.debug("Provider {} transitioned from state {} to state {}", providerName, oldState, state); |
There was a problem hiding this comment.
Should we have a higher log level when we transition into and out of the error state?
There was a problem hiding this comment.
Yes I think it's reasonable to log transitions into ERROR and FATAL states at warn/error, and going from ERROR to READY at info. Everything else at debug?
That should reduce the amount of logging noise from every state change being at info, but still having visibility of the more important provider event transitions.
2 participants
This PR
Changes the logging level of provider state change transition messages from info to debug to reduce logging noise.
Related Issues
Fixes #1986