Skip to content

Support additional columns in GoogleConversationalSearchTracer#36

Merged
viniciusdsmello merged 1 commit into
mainfrom
vini/open-11569-support-additional-columns-in-google-conversational-search
Jul 6, 2026
Merged

Support additional columns in GoogleConversationalSearchTracer#36
viniciusdsmello merged 1 commit into
mainfrom
vini/open-11569-support-additional-columns-in-google-conversational-search

Conversation

@viniciusdsmello

@viniciusdsmello viniciusdsmello commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds additional_columns: support to GoogleConversationalSearchTracer, so callers can attach custom data (e.g. a trace ID) to traced rows — as a static default per client (trace_client) and/or per individual answer_query call, with per-call values taking precedence on key conflict.
  • Keys colliding with reserved row columns (query, answer, latency_ms, timestamp, metadata, steps, context, session_id, user_id) are dropped so custom data can never corrupt core trace fields; non-Hash input is treated as empty rather than raising.
  • Updates the RBI signature and examples/google_tracer.rb to match.

Closes OPEN-11569.

Test plan

  • bundle exec rake test TEST=./test/openlayer/integrations/google_conversational_search_tracer_test.rb — 6/6 passing
  • bundle exec rubocop on all changed files — no offenses
  • bundle exec rake typecheck:sorbet — no errors
  • Two independent task reviews + one whole-branch review, all approved with no Critical/Important findings

🤖 Generated with Claude Code

https://claude.ai/code/session_01116VitmTfihHJwqBV95utA

…SearchService tracer

Extend GoogleConversationalSearchTracer to accept customer-supplied
additional columns (static per-client and per-call), so data like a
custom trace ID can be attached to imported rows. Updates the example
and RBI signature, and adds test coverage.
@viniciusdsmello viniciusdsmello force-pushed the vini/open-11569-support-additional-columns-in-google-conversational-search branch from 0e1ff58 to e5cd8df Compare July 6, 2026 13:23
@viniciusdsmello viniciusdsmello merged commit ef24b1b into main Jul 6, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants