OCPBUGS-85379: Bump documentationBaseURL to 4.22#1189
Conversation
Update DEFAULT_DOC_URL to point to OpenShift Container Platform 4.22 documentation, which is now the latest published version. Signed-off-by: Ankit Mahajan <ankimaha@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
|
@ankimaha-sys: This pull request references Jira Issue OCPBUGS-85379, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (jhadvig@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
📜 Recent review details🧰 Additional context used📓 Path-based instructions (4)**/*.go📄 CodeRabbit inference engine (AGENTS.md)
Files:
⚙️ CodeRabbit configuration file
Files:
{pkg,cmd}/**/*.go📄 CodeRabbit inference engine (CLAUDE.md)
Files:
pkg/console/subresource/**/*.go📄 CodeRabbit inference engine (ARCHITECTURE.md)
Files:
**/*.{py,js,ts,go,rs,java,rb,php,kt,swift,cs}⚙️ CodeRabbit configuration file
Files:
🔇 Additional comments (1)
WalkthroughThe default OpenShift documentation URL is updated from the 4.21 documentation page to the 4.22 documentation page. ChangesOpenShift documentation URL
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 14 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (14 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ankimaha-sys The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @ankimaha-sys. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@ankimaha-sys: This pull request references Jira Issue OCPBUGS-85379, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (jhadvig@redhat.com), skipping review request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/ok-to-test |
|
/hold |
| const ( | ||
| DEFAULT_BRAND = "ocp" | ||
| DEFAULT_DOC_URL = "https://access.redhat.com/documentation/en-us/openshift_container_platform/4.21/" | ||
| DEFAULT_DOC_URL = "https://access.redhat.com/documentation/en-us/openshift_container_platform/4.22/" |
There was a problem hiding this comment.
main currently tracks 5.0, so I'd expect this to be 5.0 here and a backport to release-4.22 to update to 4.22.
/cc @jhadvig
There was a problem hiding this comment.
- 5.0 (check the comments) OCPBUGS-85379: Bump default documentation URL to OCP 4.23 #1153
- 4.22 OCPBUGS-81121: clone bump documentation base url #1154
I think we can close this one
|
@ankimaha-sys: This pull request references Jira Issue OCPBUGS-85379. The bug has been updated to no longer refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Description
Update
DEFAULT_DOC_URLfrom 4.21 to 4.22, which is now the latest published documentation version on the Red Hat documentation site.The current
documentationBaseURLstill points to 4.21 while 4.22 documentation is already available at:https://access.redhat.com/documentation/en-us/openshift_container_platform/4.22/
Changes
pkg/console/subresource/configmap/brand_ocp.go: UpdateDEFAULT_DOC_URLconstant from4.21to4.22Bug: https://redhat.atlassian.net/browse/OCPBUGS-85379
Made with Cursor
Summary by CodeRabbit