Skip to content

OCPBUGS-85379: Bump documentationBaseURL to 4.22#1189

Closed
ankimaha-sys wants to merge 1 commit into
openshift:mainfrom
ankimaha-sys:bump-documentation-url-4.22
Closed

OCPBUGS-85379: Bump documentationBaseURL to 4.22#1189
ankimaha-sys wants to merge 1 commit into
openshift:mainfrom
ankimaha-sys:bump-documentation-url-4.22

Conversation

@ankimaha-sys

@ankimaha-sys ankimaha-sys commented Jul 14, 2026

Copy link
Copy Markdown

Description

Update DEFAULT_DOC_URL from 4.21 to 4.22, which is now the latest published documentation version on the Red Hat documentation site.

The current documentationBaseURL still points to 4.21 while 4.22 documentation is already available at:
https://access.redhat.com/documentation/en-us/openshift_container_platform/4.22/

Changes

  • pkg/console/subresource/configmap/brand_ocp.go: Update DEFAULT_DOC_URL constant from 4.21 to 4.22

Bug: https://redhat.atlassian.net/browse/OCPBUGS-85379

Made with Cursor

Summary by CodeRabbit

  • Documentation
    • Updated the default OpenShift Container Platform documentation link to point to version 4.22 resources.

Update DEFAULT_DOC_URL to point to OpenShift Container Platform 4.22
documentation, which is now the latest published version.

Signed-off-by: Ankit Mahajan <ankimaha@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jul 14, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@ankimaha-sys: This pull request references Jira Issue OCPBUGS-85379, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jhadvig@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Description

Update DEFAULT_DOC_URL from 4.21 to 4.22, which is now the latest published documentation version on the Red Hat documentation site.

The current documentationBaseURL still points to 4.21 while 4.22 documentation is already available at:
https://access.redhat.com/documentation/en-us/openshift_container_platform/4.22/

Changes

  • pkg/console/subresource/configmap/brand_ocp.go: Update DEFAULT_DOC_URL constant from 4.21 to 4.22

Bug: https://redhat.atlassian.net/browse/OCPBUGS-85379

Made with Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 7d3aaa5c-aa5c-41e3-abdc-40740a24beb9

📥 Commits

Reviewing files that changed from the base of the PR and between da112ce and fc26fc6.

📒 Files selected for processing (1)
  • pkg/console/subresource/configmap/brand_ocp.go
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • openshift/console (manual)
📜 Recent review details
🧰 Additional context used
📓 Path-based instructions (4)
**/*.go

📄 CodeRabbit inference engine (AGENTS.md)

**/*.go: Follow Go coding standards and patterns documented in CONVENTIONS.md
Organize imports according to conventions documented in CONVENTIONS.md
Use gofmt to format Go code with standard formatting
Run go vet checks on all Go packages

Follow Go coding standards and patterns as documented in CONVENTIONS.md, including proper import organization

Organize Go code following the repository structure: main entry point in cmd/console/main.go, API constants in pkg/api/, operator command setup in pkg/cmd/operator/, and version command in pkg/cmd/version/

**/*.go: Use gofmt for formatting Go code
Follow standard Go naming conventions
Group imports in order: standard lib, 3rd party, kube/openshift, internal (marked with comments)
Use meaningful error messages with context in Go code
Set status conditions using status.Handle* functions with type prefixes (*Degraded, *Progressing, *Available, *Upgradeable)
Use typed errors and wrap errors to preserve stack context

Flag MD5, SHA1, DES, RC4, 3DES, Blowfish, and ECB mode cryptographic usage. Also flag custom crypto implementations and non-constant-time comparison of secrets or tokens.

**/*.go: Do not use deprecated Go APIs such as ioutil.ReadFile, ioutil.WriteFile, ioutil.ReadAll, or net.Dial in Dial callbacks; use os.ReadFile, os.WriteFile, io.ReadAll, and DialContext instead.
When returning errors in Go, wrap them with %w and include meaningful context instead of returning the raw error or using %v.
Use specific error checks such as apierrors.IsNotFound(err) instead of matching error strings with strings.Contains(err.Error(), ...).
Propagate the caller’s context.Context through operations and avoid replacing it with context.Background() inside request/controller code.
Use defer to release acquired resources so cleanup happens on all return paths.
Avoid god functions: keep Go functions to roughly under 100 lines and split code with too many responsibilities into smaller...

Files:

  • pkg/console/subresource/configmap/brand_ocp.go

⚙️ CodeRabbit configuration file

**/*.go: Review Go code following OpenShift operator patterns.
See CONVENTIONS.md for coding standards and patterns.

Refer to the following skills based on CODE PATTERNS, not just file paths:

Refer to /controller-review when code contains:

  • Controller struct types (e.g., type *Controller struct)
  • func New*Controller( factory functions
  • factory.New().WithFilteredEventsInformers( pattern
  • .ToController( method calls
  • Sync(ctx context.Context, controllerContext factory.SyncContext) methods
  • operatorConfig.Spec.ManagementState checks
  • status.NewStatusHandler or status.Handle* functions

Refer to /sync-handler-review when code contains:

  • Main operator sync functions (e.g., sync_v400.go content)
  • Sequential resource syncing with early returns
  • Incremental reconciliation loops
  • Multiple resourceapply.Apply*() calls in sequence
  • Dependency ordering of ConfigMaps → Secrets → Service Accounts → RBAC → Services → Deployments → Routes
  • Feature gate conditional logic

Refer to /go-quality-review for all Go code to check:

  • Deprecated imports: ioutil.ReadFile, ioutil.WriteFile, ioutil.ReadAll
  • Deprecated patterns: Dial without DialContext
  • Error handling: missing %w in fmt.Errorf
  • Code smells: deep nesting (4+ levels), functions >100 lines
  • Magic values: unexplained numbers/strings
  • Context propagation: context.Background() instead of passed ctx
  • Missing godoc on exported functions

Files:

  • pkg/console/subresource/configmap/brand_ocp.go
{pkg,cmd}/**/*.go

📄 CodeRabbit inference engine (CLAUDE.md)

Use gofmt for code formatting on pkg and cmd directories

{pkg,cmd}/**/*.go: Format code using gofmt -w ./pkg ./cmd
Run go vet checks on all Go packages in ./pkg and ./cmd

Files:

  • pkg/console/subresource/configmap/brand_ocp.go
pkg/console/subresource/**/*.go

📄 CodeRabbit inference engine (ARCHITECTURE.md)

Use pkg/console/subresource/ packages for resource builders, with separate packages for each resource type (authentication, configmap, deployment, oauthclient, route, secret, etc.)

Files:

  • pkg/console/subresource/configmap/brand_ocp.go
**/*.{py,js,ts,go,rs,java,rb,php,kt,swift,cs}

⚙️ CodeRabbit configuration file

**/*.{py,js,ts,go,rs,java,rb,php,kt,swift,cs}: Injection prevention (prodsec-skills):

  • SQL: parameterized queries only; no string concatenation
  • Command: no shell=True, os.system, or backtick exec with user input
  • LDAP/XPath: escape special characters in filters
  • Path traversal: canonicalize paths, reject ../
  • Deserialization: no pickle/yaml.load()/eval on untrusted data
  • Prototype pollution: no recursive merge of untrusted objects
  • Validate at trust boundaries with allow-lists, not deny-lists
  • Normalize Unicode and anchor regexes (^$); watch for ReDoS

Files:

  • pkg/console/subresource/configmap/brand_ocp.go
🔇 Additional comments (1)
pkg/console/subresource/configmap/brand_ocp.go (1)

8-8: LGTM!


Walkthrough

The default OpenShift documentation URL is updated from the 4.21 documentation page to the 4.22 documentation page.

Changes

OpenShift documentation URL

Layer / File(s) Summary
Update default documentation URL
pkg/console/subresource/configmap/brand_ocp.go
DEFAULT_DOC_URL now references the OpenShift Container Platform 4.22 documentation URL instead of 4.21.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description covers the change and bug link, but it omits most required template sections, including root cause, tests, and reviewers. Add the missing template sections: analysis/root cause, solution details, test setup, test cases, browser conformance, additional info, and reviewers/assignees.
✅ Passed checks (14 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise, Jira-prefixed, and accurately summarizes the 4.21 to 4.22 documentation URL bump.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Only a docs URL constant changed; no test files or Ginkgo titles were modified.
Test Structure And Quality ✅ Passed PR only changes a doc URL constant; no Ginkgo tests or test files were modified, so this check is not applicable.
Microshift Test Compatibility ✅ Passed The PR only updates a doc URL constant; no new Ginkgo tests or MicroShift-sensitive APIs/features were added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only a documentation URL constant changed in brand_ocp.go; no Ginkgo tests or node/topology assumptions were added.
Topology-Aware Scheduling Compatibility ✅ Passed The only change is a doc URL constant in a configmap file; no scheduling, topology, affinity, selector, or replica logic was added.
Ote Binary Stdout Contract ✅ Passed Only DEFAULT_DOC_URL changed in a const file; no stdout-writing code or process-level setup was added.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only a docs URL constant changed; no new Ginkgo e2e tests or IPv4/external-network code were added.
No-Weak-Crypto ✅ Passed The PR only updates a documentation URL constant in brand_ocp.go; no crypto primitives, secret comparisons, or custom crypto code are introduced.
Container-Privileges ✅ Passed Only pkg/console/subresource/configmap/brand_ocp.go changed; no privileged/container security fields or manifests were modified.
No-Sensitive-Data-In-Logs ✅ Passed Only the doc URL constant changed; no logging code or sensitive-data output was added in the diff.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from jhadvig and spadgett July 14, 2026 17:43
@openshift-ci

openshift-ci Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ankimaha-sys
Once this PR has been reviewed and has the lgtm label, please assign therealjon for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 14, 2026
@openshift-ci

openshift-ci Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Hi @ankimaha-sys. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@ankimaha-sys: This pull request references Jira Issue OCPBUGS-85379, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jhadvig@redhat.com), skipping review request.

Details

In response to this:

Description

Update DEFAULT_DOC_URL from 4.21 to 4.22, which is now the latest published documentation version on the Red Hat documentation site.

The current documentationBaseURL still points to 4.21 while 4.22 documentation is already available at:
https://access.redhat.com/documentation/en-us/openshift_container_platform/4.22/

Changes

  • pkg/console/subresource/configmap/brand_ocp.go: Update DEFAULT_DOC_URL constant from 4.21 to 4.22

Bug: https://redhat.atlassian.net/browse/OCPBUGS-85379

Made with Cursor

Summary by CodeRabbit

  • Documentation
  • Updated the default OpenShift Container Platform documentation link to point to version 4.22 resources.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@spadgett

Copy link
Copy Markdown
Member

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 15, 2026
@spadgett

Copy link
Copy Markdown
Member

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 15, 2026
const (
DEFAULT_BRAND = "ocp"
DEFAULT_DOC_URL = "https://access.redhat.com/documentation/en-us/openshift_container_platform/4.21/"
DEFAULT_DOC_URL = "https://access.redhat.com/documentation/en-us/openshift_container_platform/4.22/"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

main currently tracks 5.0, so I'd expect this to be 5.0 here and a backport to release-4.22 to update to 4.22.

/cc @jhadvig

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ankimaha-sys

Copy link
Copy Markdown
Author

Thanks @spadgett and @jhadvig for the clarification. Closing in favor of #1153 and #1154.

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@ankimaha-sys: This pull request references Jira Issue OCPBUGS-85379. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

Description

Update DEFAULT_DOC_URL from 4.21 to 4.22, which is now the latest published documentation version on the Red Hat documentation site.

The current documentationBaseURL still points to 4.21 while 4.22 documentation is already available at:
https://access.redhat.com/documentation/en-us/openshift_container_platform/4.22/

Changes

  • pkg/console/subresource/configmap/brand_ocp.go: Update DEFAULT_DOC_URL constant from 4.21 to 4.22

Bug: https://redhat.atlassian.net/browse/OCPBUGS-85379

Made with Cursor

Summary by CodeRabbit

  • Documentation
  • Updated the default OpenShift Container Platform documentation link to point to version 4.22 resources.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants