[FSSDK-12879] Remove Karma testing infrastructure#1162
Merged
Conversation
Karma config files, scripts, and devDependencies are no longer used. Remove them along with the README reference. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR removes the legacy Karma-based testing infrastructure from the JavaScript SDK, including configuration files and the associated npm scripts/devDependencies.
Changes:
- Removes Karma configuration files from the repository.
- Updates
package.jsonto drop Karma test scripts and Karma-related devDependencies. - Updates documentation to stop claiming Karma is used for unit testing.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| README.md | Removes Karma mention from unit test tooling overview (but cross-browser section still needs updating). |
| package.json | Removes Karma test scripts/devDependencies; simplifies test-ci. |
| package-lock.json | Removes Karma and its dependency tree from the lockfile. |
| karma.umd.conf.js | Deleted (Karma UMD test runner config). |
| karma.local_chrome.umd.conf.js | Deleted (local Chrome UMD Karma config). |
| karma.local_chrome.bs.conf.js | Deleted (local Chrome BrowserStack Karma config). |
| karma.bs.conf.js | Deleted (BrowserStack Karma config). |
| karma.base.conf.js | Deleted (shared Karma base config). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
coverage: 77.701% (-0.02%) from 77.724% — raju/karma into master |
raju-opti
changed the title
junaed-optimizely
approved these changes
Jul 7, 2026
Comment on lines
+233
to
+234
| 4. Run `npm run test-mocha` to run only tests written using Mocha. | ||
| 4. (For cross-browser testing) Run `npm run test-xbrowser` to run tests in many browsers via BrowserStack. | ||
| 4. (For cross-browser testing) Run `npm run test-browser-browserstack` to run browser tests via BrowserStack, or `npm run test-browser-local` to run them locally. |
Contributor
There was a problem hiding this comment.
NIT: Nothing related to this PR, but could we fix the numbering order of this list ? Looks like there are two "4" now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Karma config files, scripts, and devDependencies are no longer used. Remove them along with the README reference.