-
Notifications
You must be signed in to change notification settings - Fork 29
Add test for offchain-worker
#139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
naijauser
wants to merge
18
commits into
paritytech:main
Choose a base branch
from
naijauser:10-add-offchain-worker-test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+133
−0
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
b3d8daf
add extra logs to state
naijauser ff5b7f5
add logging
naijauser 3140930
update
naijauser 9371c41
remove debug logs
naijauser a9949f4
setup offchain worker test scaffolding
naijauser c2fa6df
import duration
naijauser 28b4a94
add happy path test
naijauser b9d78ba
add import
naijauser df52160
cargo fmt
naijauser b99e2d8
cargo_bin is a macro
naijauser 866aa3e
update command arguments
naijauser 0578289
add error state test for offchain worker
naijauser cda0204
refactor
naijauser 2cd947b
update
naijauser 7be02c0
refactor
naijauser 324642b
fmt
naijauser 612a320
remove logs from state file
naijauser d22fa38
remove newline
naijauser File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,133 @@ | ||
| // This file is part of try-runtime-cli. | ||
|
|
||
| // Copyright (C) Parity Technologies (UK) Ltd. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| #![cfg(unix)] | ||
| #![allow(deprecated)] | ||
|
|
||
| use std::time::Duration; | ||
|
|
||
| use assert_cmd::cargo_bin; | ||
| use regex::Regex; | ||
| use substrate_cli_test_utils as common; | ||
| use tokio::process::Command; | ||
|
|
||
| #[tokio::test] | ||
| async fn offchain_worker_works() { | ||
| let port = 45789; | ||
|
|
||
| // Spawn a dev node. | ||
| let _ = std::thread::spawn(move || { | ||
| match common::start_node_inline(vec![ | ||
| "--no-hardware-benchmarks", | ||
| "--dev", | ||
| format!("--rpc-port={}", port).as_str(), | ||
| ]) { | ||
| Ok(_) => {} | ||
| Err(e) => { | ||
| panic!("Node exited with error: {}", e); | ||
| } | ||
| } | ||
| }); | ||
|
|
||
| // Wait some time to ensure that the node is warmed up. | ||
| std::thread::sleep(Duration::from_secs(90)); | ||
|
|
||
| // Test ok | ||
| common::run_with_timeout(Duration::from_secs(60), async move { | ||
| let ws_url = format!("ws://localhost:{}", port); | ||
|
|
||
| fn run_offchain_worker(ws_url: &str) -> tokio::process::Child { | ||
| let path = cargo_bin!("try-runtime"); | ||
|
|
||
| assert!( | ||
| path.exists(), | ||
| "try-runtime binary not found at path: {}", | ||
| path.display() | ||
| ); | ||
|
|
||
| Command::new(path) | ||
| .stdout(std::process::Stdio::piped()) | ||
| .stderr(std::process::Stdio::piped()) | ||
| .arg("--runtime=existing") | ||
| .arg("offchain-worker") | ||
| .args(["live", format!("--uri={}", ws_url).as_str()]) | ||
| .kill_on_drop(true) | ||
| .spawn() | ||
| .unwrap() | ||
| } | ||
|
|
||
| // Try to run offchain-worker command | ||
| let offchain_execution = run_offchain_worker(&ws_url); | ||
|
|
||
| // Assert that command runs to completion successfully | ||
| assert!(offchain_execution | ||
| .wait_with_output() | ||
| .await | ||
| .unwrap() | ||
| .status | ||
| .success()); | ||
| }) | ||
| .await; | ||
|
|
||
| // Test attempting to use non-live state. Should terminate with error. | ||
| common::run_with_timeout(Duration::from_secs(60), async move { | ||
| let ws_url = format!("ws://localhost:{}", port); | ||
|
|
||
| fn run_offchain_worker_snap_state(ws_url: &str) -> tokio::process::Child { | ||
| let path = cargo_bin!("try-runtime"); | ||
|
|
||
| assert!( | ||
| path.exists(), | ||
| "try-runtime binary not found at path: {}", | ||
| path.display() | ||
| ); | ||
|
|
||
| let project_root = env!("CARGO_MANIFEST_DIR"); | ||
| let snap_file_path = format!("{}/tests/snaps/rococo-people.snap", project_root); | ||
|
|
||
| Command::new(path) | ||
| .stdout(std::process::Stdio::piped()) | ||
| .stderr(std::process::Stdio::piped()) | ||
| .arg("--runtime=existing") | ||
| .arg("offchain-worker") | ||
| .args(["--header-ws-uri", ws_url]) | ||
| .args(["snap", "--path", snap_file_path.as_str()]) | ||
| .kill_on_drop(true) | ||
| .spawn() | ||
| .unwrap() | ||
| } | ||
|
|
||
| // Try to execute command | ||
| let mut offchain_execution = run_offchain_worker_snap_state(&ws_url); | ||
| let expected_output = r"execute block currently only supports Live state"; | ||
| let re = Regex::new(expected_output).unwrap(); | ||
| let matched = | ||
| common::wait_for_stream_pattern_match(offchain_execution.stderr.take().unwrap(), re) | ||
| .await; | ||
|
|
||
| assert!(matched.is_ok()); | ||
|
|
||
| // Assert that the command did not exit successfully | ||
| assert!(!offchain_execution | ||
| .wait_with_output() | ||
| .await | ||
| .unwrap() | ||
| .status | ||
| .success()); | ||
| }) | ||
| .await; | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is actually doing two separate things:
Now, I get that this is done to avoid having to spin up a process twice for what is essentially the same test (good decision); there's just a bit of clarity missing.
Could you write a top-level comment on the test like I asked you to do in PET? As usual, future selves will appreciate it.