Skip to content

Mark version.xml files as do-not-translate#5662

Merged
alfsb merged 1 commit into
php:masterfrom
alfsb:ignore-version-files
Jul 15, 2026
Merged

Mark version.xml files as do-not-translate#5662
alfsb merged 1 commit into
php:masterfrom
alfsb:ignore-version-files

Conversation

@alfsb

@alfsb alfsb commented Jul 9, 2026

Copy link
Copy Markdown
Member

This is the secontd part of #5657. This is not marked as skip-revcheck as these files are expected to not exist in translations.

All <!-- $Revisions$ --> removed, some ws normalized. No functional differences detected.

Plan to merge this next wednesday, if 5657 goes ok.

@kamil-tekiela kamil-tekiela left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not going to look at every file. I trust you didn't sneak any typos.

Please change the PR title to "Add in versions.xml files"

@alfsb alfsb changed the title Automatically generated files must self-declare Add in versions.xml files Jul 10, 2026
@alfsb

alfsb commented Jul 10, 2026

Copy link
Copy Markdown
Member Author

Please change the PR title to "Add in versions.xml files"

Changed. But it makes sense? I'm considered "Mark version.xml files as do-not-translate"

@kamil-tekiela

Copy link
Copy Markdown
Member

Please change the PR title to "Add in versions.xml files"

Changed. But it makes sense? I'm considered "Mark version.xml files as do-not-translate"

Yes. That's even better.

@alfsb alfsb changed the title Add in versions.xml files Mark version.xml files as do-not-translate Jul 10, 2026
@alfsb
alfsb merged commit c2149ab into php:master Jul 15, 2026
2 checks passed
@alfsb
alfsb deleted the ignore-version-files branch July 15, 2026 14:13
@alfsb

alfsb commented Jul 15, 2026

Copy link
Copy Markdown
Member Author

Post test results in identical XML on configure.php, as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants