Edge-case hardening: NaN input, leaderboard throttle, party rematch#3
Merged
Conversation
Blobs: reject non-finite move input (NaN would corrupt position/score irrecoverably); throttle leaderboard submits from every tick (20 Hz × players) to once per 5s per player. Siege: reject non-finite move direction; add the director bookkeeping fields (_spawned/_clearedAt/_restartAt) to the State type. Caption Clash: after the results screen, auto-return to a fresh lobby (scores reset, present players kept) instead of stranding everyone on the final scoreboard; drop a departed player's caption so it isn't left voteable with no author. Comment explaining why Party uses the raw plot.join() API (turn-based → no predict/interpolate) while Blobs/Siege use the managed plot.play(). Tests: +14 handler tests (NaN rejection, throttle, rematch, submission cleanup). Full showcase suite 49 pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardens all three games against the edge cases found in review:
+14 handler tests; full showcase suite 49 pass. Handlers already republished to WfP.