fix: vendored client treats idle-eviction (4008) as terminal#4
Merged
Conversation
…rminal The platform's rooms now evict idle connections with close code 4008 (no client input for the idle window). The old vendored client treated any non-1000 close as abnormal and auto-reconnected — an idle open tab would reconnect every few minutes forever, keeping its room ticking. The refreshed bundle treats 4008 as a clean, terminal close (no retry) and adds the npcChunk event for streamed NPC lines. Type sidecars (protocol/handler/handler-client) refreshed to match. 49 tests + typecheck + build green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platform rooms now close idle connections with code 4008. The old vendored client auto-reconnected on any non-1000 close, so an idle tab would reconnect-cycle forever and keep its room alive. Refreshed self-contained bundle from the platform repo: 4008 = clean terminal close (no retry) + npcChunk event + refreshed type sidecars. Tests/typecheck/build green.