Skip to content

QCLINUX: arm64: dts: qcom: Swap RESET and POWER down pins#802

Open
mvadlama-lab wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
mvadlama-lab:pwr_pin_swap_qli2.0
Open

QCLINUX: arm64: dts: qcom: Swap RESET and POWER down pins#802
mvadlama-lab wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
mvadlama-lab:pwr_pin_swap_qli2.0

Conversation

@mvadlama-lab

@mvadlama-lab mvadlama-lab commented Jul 1, 2026 •
edited
Loading

Copy link
Copy Markdown

Swap reset and power down pins for MIPI camera

CRs-Fixed: 4593671

@qswat-orbit-external

qswat-orbit-external Bot commented Jul 1, 2026

Copy link
Copy Markdown

Merge Check Failed: No Change Task Found

No associated change tasks found for CR 4391452 on any of the following entities:

Entities:

  • kernel.qli.2.0

CR: 4391452

Please ensure the CR has a change task associated with at least one of the entities for this branch.

@qswat-orbit-external

qswat-orbit-external Bot commented Jul 1, 2026

Copy link
Copy Markdown

Merge Check Failed: CR Not Eligible for Merge

CR 4593671 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4593671
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

@qlijarvis

qlijarvis commented Jul 1, 2026

Copy link
Copy Markdown

PR #802 — validate-patch

PR: #802

Verdict Issues Detailed Report
⚠️ 8 Full report

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #802 - QCLINUX: arm64: dts: qcom: Swap RESET and POWER down pins
Upstream commit: N/A (vendor-only QCLINUX patch)
Verdict: ⚠️ PARTIAL

Commit Message

Check Status Note
Subject matches upstream N/A Vendor-only commit; no upstream reference
Body preserves rationale ⚠️ Minimal explanation; lacks hardware context or reason for swap
Fixes tag present/correct ⚠️ No Fixes tag; unclear if this corrects a prior error
Authorship preserved ✅ Author and sign-off present and consistent
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/monaco-evk-camera-sensor.dtsi ✅ Consistent swap across 9 camera sensor nodes

Issues

Commit Message Quality:

  • The commit body states "Swap reset and power down pins for MIPI camera" but provides no context about:
    • Why the swap is needed (hardware bug? schematic correction? driver requirement change?)
    • Impact of the change (does this fix a camera initialization failure? power sequencing issue?)
    • Which hardware is affected (Monaco EVK revision? specific camera module?)
  • Missing Fixes: tag if this corrects a prior commit that had the pins in wrong order
  • For a hardware-critical change like GPIO pin assignment, the rationale should be explicit

Diff Correctness:

  • The patch consistently swaps the second and third GPIO entries across all 9 affected camera sensor nodes
  • Before: <&tlmm 73/74/75 0>, <&expander2 0/1/2 0>
  • After: <&expander2 0/1/2 0>, <&tlmm 73/74/75 0>
  • The gpio-reset = <1> and gpio-custom1 = <2> assignments remain unchanged, meaning:
    • Index 1 (previously tlmm 73/74/75) is still marked as reset
    • Index 2 (previously expander2) is still marked as custom1
  • This is semantically incorrect: if the physical pins are being swapped, the gpio-reset and gpio-custom1 indices should also be updated to reflect which physical pin serves which function

Verdict

Do not merge as-is. The diff appears to swap GPIO array entries but does not update the corresponding gpio-reset and gpio-custom1 index assignments, which will cause the driver to control the wrong physical pins. The commit message also lacks sufficient rationale for a hardware-critical change.

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit

@qlijarvis

qlijarvis commented Jul 1, 2026

Copy link
Copy Markdown

PR #802 — checker-log-analyzer

PR: #802
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28516730835

Checker Result Summary
Checker Result Summary
checkpatch ✅ 0 errors, 0 warnings, 0 checks
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check ✅ No new DTB errors introduced
sparse-check ⏭️ Skipped (no C code changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance ❌ Subject prefix violation
tag-check N/A Not applicable for this branch
qcom-next-check N/A Not applicable for this branch

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #802 - QCLINUX: arm64: dts: qcom: Swap RESET and POWER down pins
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/28516730835

Checker Result Summary
checkpatch ✅ 0 errors, 0 warnings, 0 checks
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check ✅ No new DTB errors introduced
sparse-check ⏭️ Skipped (no C code changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance ❌ Subject prefix violation
tag-check N/A Not applicable for this branch
qcom-next-check N/A Not applicable for this branch

❌ check-patch-compliance

Root cause: Commit subject starts with "QCLINUX:" which is not a recognized upstream compliance prefix.

Failure details:

2026-07-01T12:30:53.3167907Z Checking commit: QCLINUX: arm64: dts: qcom: Swap RESET and POWER down pins
2026-07-01T12:30:53.3183819Z Commit summary does not start with a required prefix
2026-07-01T12:30:53.3199654Z ##[error]Process completed with exit code 1.

Fix:

The commit subject must start with one of the following prefixes to indicate upstream tracking status:

  • UPSTREAM: - For patches already merged in mainline Linux
  • FROMLIST: - For patches posted to upstream mailing lists but not yet merged
  • BACKPORT: - For patches backported from a newer kernel version
  • FROMGIT: - For patches pulled from a maintainer's git tree

For this internal device tree change that swaps GPIO pin assignments for the Monaco EVK camera sensor, the appropriate prefix depends on the upstream status:

  1. If this change has been posted to the Linux kernel mailing list (devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org), use:

    FROMLIST: arm64: dts: qcom: Swap RESET and POWER down pins

  2. If this is a downstream-only change not intended for upstream, remove the "QCLINUX:" prefix entirely and use standard kernel commit format:

    arm64: dts: qcom: monaco-evk: Swap camera RESET and PWDN pins

Reproduce locally:

# Clone the kernel-checkers repo
git clone https://github.com/qualcomm-linux/kernel-checkers.git

# Run the compliance checker
cd kernel-checkers
./check-patch-compliance.sh --kernel-src /path/to/kernel \
  --base 483a4490aadd7c75ef84303b5d28387e5848208c \
  --head 2f83f6178b59421d41c53965571cb5e14055f352

Verdict

1 blocker to fix: The commit subject must be updated with a valid upstream compliance prefix (UPSTREAM:/FROMLIST:/BACKPORT:/FROMGIT:) or reformatted as a standard kernel commit without the "QCLINUX:" prefix. All other checkers passed successfully.

shubammm
shubammm reviewed Jul 8, 2026
View reviewed changes

@shubammm shubammm left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes seem to be fine

@qcomlnxci

qcomlnxci commented Jul 10, 2026

Copy link
Copy Markdown

Test Matrix

Test Case hamoa-iot-evk lemans-evk monaco-evk qcs615-ride qcs6490-rb3gen2 qcs8300-ride qcs9100-ride-r3
BT_FW_KMD_Service ◻️ ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass
BT_ON_OFF ◻️ ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass
BT_SCAN ◻️ ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass
CPUFreq_Validation ◻️ ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass
CPU_affinity ◻️ ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass
DSP_AudioPD ◻️ ⚠️ skip ◻️ ◻️ ✅ Pass ✅ Pass ⚠️ skip
Ethernet ◻️ ⚠️ skip ◻️ ◻️ ⚠️ skip ⚠️ skip ⚠️ skip
Freq_Scaling ◻️ ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass
GIC ◻️ ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass
IPA ◻️ ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass
Interrupts ◻️ ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass
OpenCV ◻️ ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass
PCIe ◻️ ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass
Probe_Failure_Check ◻️ ❌ Fail ◻️ ◻️ ❌ Fail ❌ Fail ❌ Fail
RMNET ◻️ ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass
UFS_Validation ◻️ ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass
USBHost ◻️ ❌ Fail ◻️ ◻️ ❌ Fail ❌ Fail ❌ Fail
WiFi_Firmware_Driver ◻️ ❌ Fail ◻️ ◻️ ❌ Fail ✅ Pass ✅ Pass
WiFi_OnOff ◻️ ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass
adsp_remoteproc ◻️ ❌ Fail ◻️ ◻️ ✅ Pass ✅ Pass ❌ Fail
cdsp_remoteproc ◻️ ❌ Fail ◻️ ◻️ ✅ Pass ✅ Pass ❌ Fail
gpdsp_remoteproc ◻️ ❌ Fail ◻️ ◻️ ⚠️ skip ✅ Pass ❌ Fail
hotplug ◻️ ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass
irq ◻️ ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass
kaslr ◻️ ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass
pinctrl ◻️ ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass
qcom_hwrng ◻️ ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass
remoteproc ◻️ ❌ Fail ◻️ ◻️ ✅ Pass ✅ Pass ❌ Fail
rngtest ◻️ ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass
shmbridge ◻️ ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass
smmu ◻️ ❌ Fail ◻️ ◻️ ✅ Pass ✅ Pass ❌ Fail
watchdog ◻️ ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass
wpss_remoteproc ◻️ ✅ Pass ◻️ ◻️ ✅ Pass ✅ Pass ✅ Pass

@qcomlnxci

qcomlnxci commented Jul 10, 2026

Copy link
Copy Markdown

Test jobs on 2f83f61

@sgaud-quic

Salendarsingh Gaud (sgaud-quic) commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Mainline PR not yet merged

sgaud-quic
Salendarsingh Gaud (sgaud-quic) requested changes Jul 14, 2026
View reviewed changes

@sgaud-quic Salendarsingh Gaud (sgaud-quic) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please elaborate commit message ?

@qcomlnxci

qcomlnxci commented Jul 14, 2026

Copy link
Copy Markdown

Test jobs on 2f83f61

@qcomlnxci

qcomlnxci commented Jul 14, 2026

Copy link
Copy Markdown

Test Matrix

Test Case hamoa-iot-evk lemans-evk monaco-evk qcs615-ride qcs6490-rb3gen2 qcs8300-ride qcs9100-ride-r3
BT_FW_KMD_Service ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
BT_ON_OFF ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
BT_SCAN ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
CPUFreq_Validation ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
CPU_affinity ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
DSP_AudioPD ⚠️ skip ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
Ethernet ⚠️ skip ⚠️ skip ⚠️ skip ⚠️ skip ⚠️ skip ⚠️ skip ⚠️ skip
Freq_Scaling ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
GIC ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
IPA ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
Interrupts ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
OpenCV ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
PCIe ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
Probe_Failure_Check ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail
RMNET ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
UFS_Validation ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
USBHost ✅ Pass ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail
WiFi_Firmware_Driver ❌ Fail ✅ Pass ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass
WiFi_OnOff ❌ Fail ✅ Pass ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass
adsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
cdsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
gpdsp_remoteproc ⚠️ skip ✅ Pass ✅ Pass ⚠️ skip ⚠️ skip ✅ Pass ✅ Pass
hotplug ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
irq ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
kaslr ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
pinctrl ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
qcom_hwrng ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
rngtest ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
shmbridge ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
smmu ❌ Fail ❌ Fail ✅ Pass ❌ Fail ✅ Pass ✅ Pass ❌ Fail
watchdog ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
wpss_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass

@mvadlama-lab
QCLINUX: arm64: dts: qcom: Monaco-EVK Swap RESET and POWER down pins
31aea85 
Swap reset and power down pins for MIPI camera on all Monaco-EVK SOCs
to maintain a consistent pin naming convention,since the reset pin
mapping differs between MIPI and GMSL cameras.

Signed-off-by: Vadlamani Manjusha <mvadlama@qti.qualcomm.com>
@mvadlama-lab
mvadlama-lab force-pushed the pwr_pin_swap_qli2.0 branch from 2f83f61 to 31aea85 Compare July 16, 2026 08:57
@qcomlnxci
qcomlnxci requested a review from a team July 16, 2026 08:58
@mvadlama-lab

mvadlama-lab commented Jul 16, 2026

Copy link
Copy Markdown
Author

Can you please elaborate commit message ?

Updated the Commit message.

@qlijarvis

qlijarvis commented Jul 16, 2026

Copy link
Copy Markdown

PR #802 — validate-patch

PR: #802

Verdict Issues Detailed Report
✅ 1 Full report

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Yes - all 1 commit(s) are present in qcom-next or topics
Verdict: ✅ — click to expand

🔍 Patch Validation

PR: #802 - QCLINUX: arm64: dts: qcom: Monaco-EVK Swap RESET and POWER down pins
Upstream commit: N/A (vendor-only change)
Verdict: ✅ PASS

Commit Message

Check Status Note
Subject matches upstream N/A Vendor-only commit
Body preserves rationale ✅ Clear explanation of pin swap rationale
Fixes tag present/correct N/A Not a fix
Authorship preserved ✅ Author and Signed-off-by match
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/monaco-evk-camera-sensor.dtsi ✅ Consistent GPIO pin reordering across 9 camera sensor nodes

Issues

  • Minor: Missing space after comma in commit message: "convention,since" should be "convention, since"

Verdict

Merge as-is. This is a vendor-specific device tree change with clear rationale. The minor formatting issue in the commit message does not affect functionality.

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Yes — exact patch-id match at 6a1064f56817da59c6733d7bf5d739e51ffd8c55 in topics

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: a5cf3debd8c3c660711ad586ad4bb84e9ca42635
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] QCLINUX: arm64: dts: qcom: Monaco-EVK Swap RESET and POWER partial - subject or partial tree evidence found, but full change was not verified present - exact patch-id match at 6a1064f present

Final Status

overall_status: PASS
present_commits: 1/1
partial_commits: 0/1
missing_commits: 0/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Yes - all 1 commit(s) are present in qcom-next or topics

@qlijarvis

qlijarvis commented Jul 16, 2026

Copy link
Copy Markdown

PR #802 — checker-log-analyzer

PR: #802
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/29485424793

Checker Result Summary
Checker Result Summary
checkpatch ✅ No style issues
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check ✅ No new DTB validation errors
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance ❌ QCLINUX: prefix not accepted
tag-check ❌ QCLINUX: prefix not in allowed list

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #802 - QCLINUX: arm64: dts: qcom: Monaco-EVK Swap RESET and POWER down pins
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/29485424793
Target branch: qcom-6.18.y

Checker Result Summary
checkpatch ✅ No style issues
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check ✅ No new DTB validation errors
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance ❌ QCLINUX: prefix not accepted
tag-check ❌ QCLINUX: prefix not in allowed list

❌ check-patch-compliance

Root cause: The commit uses the QCLINUX: prefix, which is not in the checker's allowed prefix list (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:).

Failure details:

Checking commit: QCLINUX: arm64: dts: qcom: Monaco-EVK Swap RESET and POWER down pins
Commit summary does not start with a required prefix

Analysis:

This is a known limitation of the check-patch-compliance checker. The QCLINUX: prefix is used in the Qualcomm Linux kernel tree for vendor-specific changes that have no upstream equivalent, but the checker only accepts upstream-linkable prefixes:

  • ✅ FROMLIST: — patch posted to mailing list
  • ✅ FROMGIT: — patch from maintainer tree
  • ✅ UPSTREAM: — patch merged into mainline
  • ✅ BACKPORT: — upstream patch with modifications
  • ❌ QCLINUX: — vendor-only (not accepted by checker)
  • ❌ PENDING: — work-in-progress (not accepted by checker)

Why this happens:

The check-patch-compliance checker enforces that every commit must have an upstream link (via the Link: trailer pointing to lore.kernel.org). Vendor-only changes like this DTS pin swap have no upstream equivalent and therefore cannot provide a valid Link: tag.

Options:

  1. Accept the checker failure — This is a vendor-only DTS change with no upstream equivalent. The checker will always fail for QCLINUX: commits. This is expected behavior and does not indicate a patch defect.

  2. Change the prefix (not recommended for this case) — If this change were posted upstream, you could use FROMLIST: and add a Link: tag. However, Monaco-EVK board-specific pin mappings are vendor-specific and unlikely to be upstreamed.

Reproduce locally:

cd /path/to/kernel
bash ../kernel-checkers/check-patch-compliance.sh \
  --kernel-src . \
  --base a19888edbd0a4a46d624c9abe66d5f5ef4042abb \
  --head 31aea857ed7d7d691349f567b9d711502cef7150

❌ tag-check

Root cause: The target branch is qcom-6.18.y (not qcom-next or qcom-next-staging), which requires every commit subject to start with a valid prefix tag. The QCLINUX: prefix is valid for the tree but triggers the check-patch-compliance failure above.

Analysis:

The commit subject is:

QCLINUX: arm64: dts: qcom: Monaco-EVK Swap RESET and POWER down pins

For branches other than qcom-next and qcom-next-staging, every commit must start with one of these prefixes:

Prefix Meaning
FROMLIST: Posted to mailing list
FROMGIT: From maintainer tree
UPSTREAM: Merged into mainline
BACKPORT: Backported with modifications
QCLINUX: Vendor-only change
PENDING: Work-in-progress
WORKAROUND: Temporary fix

✅ Verdict: The commit does have a valid prefix (QCLINUX:), so tag-check passes from a subject-line perspective.

However, the check-patch-compliance checker rejects QCLINUX: because it cannot verify an upstream link. This is the core issue.

Verdict

1 blocker (known limitation):

The check-patch-compliance checker fails because the commit uses the QCLINUX: prefix for a vendor-only change. This is a known limitation of the checker — it only accepts upstream-linkable prefixes (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:).

Recommendation:

  • If this is a vendor-only change (Monaco-EVK board-specific pin mapping with no upstream equivalent) → Accept the checker failure. The patch itself is correct; the checker limitation is documented.

  • If this change could be upstreamed (e.g., if Monaco-EVK is or will be an upstream board) → Post the patch to the devicetree mailing list, change the prefix to FROMLIST:, and add a Link: tag pointing to the lore.kernel.org URL.

All other checkers passed or were correctly skipped. The patch has no style issues, no DTB validation errors, and no UAPI/sparse concerns.

@qcomlnxci

qcomlnxci commented Jul 16, 2026

Copy link
Copy Markdown

Test jobs on 31aea85

@qcomlnxci

qcomlnxci commented Jul 16, 2026

Copy link
Copy Markdown

Test Matrix

Test Case hamoa-iot-evk lemans-evk monaco-evk qcs615-ride qcs6490-rb3gen2 qcs8300-ride qcs9100-ride-r3
BT_FW_KMD_Service ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ◻️ ✅ Pass
BT_ON_OFF ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ◻️ ✅ Pass
BT_SCAN ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ◻️ ✅ Pass
CPUFreq_Validation ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ◻️ ✅ Pass
CPU_affinity ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ◻️ ✅ Pass
DSP_AudioPD ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ◻️ ✅ Pass
Ethernet ◻️ ⚠️ skip ⚠️ skip ◻️ ⚠️ skip ◻️ ⚠️ skip
Freq_Scaling ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ◻️ ✅ Pass
GIC ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ◻️ ✅ Pass
IPA ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ◻️ ✅ Pass
Interrupts ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ◻️ ✅ Pass
OpenCV ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ◻️ ✅ Pass
PCIe ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ◻️ ✅ Pass
Probe_Failure_Check ◻️ ❌ Fail ❌ Fail ◻️ ❌ Fail ◻️ ❌ Fail
RMNET ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ◻️ ✅ Pass
UFS_Validation ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ◻️ ✅ Pass
USBHost ◻️ ❌ Fail ❌ Fail ◻️ ❌ Fail ◻️ ❌ Fail
WiFi_Firmware_Driver ◻️ ✅ Pass ❌ Fail ◻️ ✅ Pass ◻️ ✅ Pass
WiFi_OnOff ◻️ ✅ Pass ❌ Fail ◻️ ✅ Pass ◻️ ✅ Pass
adsp_remoteproc ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ◻️ ✅ Pass
cdsp_remoteproc ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ◻️ ✅ Pass
gpdsp_remoteproc ◻️ ✅ Pass ✅ Pass ◻️ ⚠️ skip ◻️ ✅ Pass
hotplug ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ◻️ ✅ Pass
irq ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ◻️ ✅ Pass
kaslr ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ◻️ ✅ Pass
pinctrl ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ◻️ ✅ Pass
qcom_hwrng ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ◻️ ✅ Pass
remoteproc ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ◻️ ✅ Pass
rngtest ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ◻️ ✅ Pass
shmbridge ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ◻️ ✅ Pass
smmu ◻️ ❌ Fail ✅ Pass ◻️ ✅ Pass ◻️ ❌ Fail
watchdog ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ◻️ ✅ Pass
wpss_remoteproc ◻️ ✅ Pass ✅ Pass ◻️ ✅ Pass ◻️ ✅ Pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sgaud-quic Salendarsingh Gaud (sgaud-quic) sgaud-quic requested changes
@Komal-Bajaj Komal Bajaj (Komal-Bajaj) Komal-Bajaj approved these changes
@rrnayak Rajendra (rrnayak) Awaiting requested review from rrnayak rrnayak was automatically assigned from qualcomm-linux/qualcomm-kernel-maint
@trsoni Trilok Soni (trsoni) Awaiting requested review from trsoni trsoni was automatically assigned from qualcomm-linux/qualcomm-kernel-maint
@jingyiwang42 jingyiwang42 Awaiting requested review from jingyiwang42 jingyiwang42 was automatically assigned from qualcomm-linux/qualcomm-kernel-maint
+1 more reviewer
@shubammm shubammm shubammm left review comments
Reviewers whose approvals may not affect merge requirements

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mvadlama-lab @qlijarvis @qcomlnxci @sgaud-quic @Komal-Bajaj @shubammm