Skip to content

FROMLIST: Add Coresight nodes for Shikra#824

Open
Jie Gan (jiegan0107) wants to merge 2 commits into
qualcomm-linux:qcom-6.18.yfrom
jiegan0107:shikra-coresight
Open

FROMLIST: Add Coresight nodes for Shikra#824
Jie Gan (jiegan0107) wants to merge 2 commits into
qualcomm-linux:qcom-6.18.yfrom
jiegan0107:shikra-coresight

Conversation

@jiegan0107

Copy link
Copy Markdown

Add DT nodes for the CoreSight debug and trace subsystem on Qualcomm Shikra SoC.

CRs-Fixed: 4607858

@qlijarvis

Copy link
Copy Markdown

PR #824 — validate-patch

PR: #824

Verdict Issues Detailed Report
⚠️ 2 Full report

Final Summary

  1. Lore link present: Yes — both commits have correctly formatted Link: tags pointing to lore.kernel.org
  2. Lore link matches PR commits: ⏭️ Cannot verify — network restrictions prevent fetching lore patches for comparison
  3. Upstream patch status: ⏭️ Cannot verify — network restrictions prevent fetching lore threads to check acceptance/rejection signals
  4. PR present in qcom-next:
    • Commit 1/2: Noqcom,shikra-ctcu not found in qcom-next
    • Commit 2/2: Partial — Different version found as 5f9f6b52570d with significantly different stats (+111 insertions, +98 deletions difference)
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #824 — Add CTCU device and coresight nodes for shikra
Commits: 2 commits (both FROMLIST)


Commit 1/2: FROMLIST: dt-bindings: arm: add CTCU device for shikra

Upstream commit: https://lore.kernel.org/all/20260714-add-coresight-nodes-for-shikra-v1-1-b1cf85962455@oss.qualcomm.com/
Verdict: ⚠️ PARTIAL — Cannot verify diff faithfulness (network restricted); commit message structure correct

Commit Message

Check Status Note
Subject matches upstream ⏭️ Skipped Cannot fetch lore patch (network restricted)
Body preserves rationale ✅ Pass Clear description of CTCU fallback to SA8775p
Fixes tag present/correct N/A Not a fix commit
Authorship preserved ⏭️ Skipped FROMLIST: lore author in Signed-off-by (cannot verify From: without lore fetch)
Backport note (if applicable) N/A Not a backport
Link tag present ✅ Pass Link: tag present and correctly formatted

Diff

File Status Notes
Documentation/devicetree/bindings/arm/qcom,coresight-ctcu.yaml ⏭️ Skipped Cannot compare to lore patch (network restricted)

Upstream Patch Status

⏭️ Skipped — Cannot fetch lore thread to determine acceptance status (network restricted)

qcom-next Presence

⚠️ Not in qcom-next — Searched by file path and subject; qcom,shikra-ctcu not present in origin/qcom-next:Documentation/devicetree/bindings/arm/qcom,coresight-ctcu.yaml

Issues

  • Network restriction: Cannot fetch lore patch to verify diff faithfulness or upstream acceptance status
  • qcom-next absence: Commit not found in qcom-next; may not have landed yet

Verdict

Cannot fully validate due to network restrictions. Commit message structure is correct (FROMLIST prefix, Link tag, Signed-off-by present). Manual verification required: fetch lore patch and compare diff when network access is available.


Commit 2/2: FROMLIST: arm64: dts: qcom: shikra: Add coresight nodes

Upstream commit: https://lore.kernel.org/all/20260714-add-coresight-nodes-for-shikra-v1-2-b1cf85962455@oss.qualcomm.com/
Verdict: ⚠️ PARTIAL — qcom-next version differs; cannot verify lore faithfulness (network restricted)

Commit Message

Check Status Note
Subject matches upstream ⏭️ Skipped Cannot fetch lore patch (network restricted)
Body preserves rationale ✅ Pass Clear description of CoreSight subsystem addition
Fixes tag present/correct N/A Not a fix commit
Authorship preserved ⏭️ Skipped FROMLIST: lore author in Signed-off-by (cannot verify From: without lore fetch)
Backport note (if applicable) N/A Not a backport
Link tag present ✅ Pass Link: tag present and correctly formatted

Diff

File Status Notes
arch/arm64/boot/dts/qcom/shikra.dtsi ⚠️ Warning PR: +1499/-200 lines; qcom-next 5f9f6b52570d: +1388/-102 lines — stats differ significantly

Upstream Patch Status

⏭️ Skipped — Cannot fetch lore thread to determine acceptance status (network restricted)

qcom-next Presence

⚠️ Different version in qcom-next — Found as 5f9f6b52570d but:

  • qcom-next commit lacks FROMLIST: prefix and Link: tag
  • qcom-next commit date: Fri May 8 21:56:00 2026 vs PR: Tue, 14 Jul 2026 16:22:37
  • qcom-next stats: +1388/-102 vs PR: +1499/-200209 more insertions, 98 more deletions in PR

This suggests the PR contains a newer or different revision than what landed in qcom-next.

Issues

  1. Network restriction: Cannot fetch lore patch to verify diff faithfulness or upstream acceptance status
  2. qcom-next divergence: PR commit differs significantly from qcom-next version:
    • Different line counts (+111 insertions, +98 deletions)
    • Different commit metadata (date, prefix, Link tag)
    • Possible causes:
      • PR is a newer lore revision (v2, v3, etc.) not yet in qcom-next
      • PR includes additional changes beyond the qcom-next commit
      • qcom-next commit was an earlier version before FROMLIST prefix was added

Verdict

Review required. The PR commit has significantly more changes than the qcom-next version. Without lore access, cannot determine if:

  • The extra changes are legitimate updates from a newer lore revision, or
  • The PR incorrectly bundles unrelated changes

Recommendation: Manually verify the lore link when network access is available to confirm the PR matches the posted patch series.


Final Summary

  1. Lore link present: Yes — both commits have correctly formatted Link: tags pointing to lore.kernel.org
  2. Lore link matches PR commits: ⏭️ Cannot verify — network restrictions prevent fetching lore patches for comparison
  3. Upstream patch status: ⏭️ Cannot verify — network restrictions prevent fetching lore threads to check acceptance/rejection signals
  4. PR present in qcom-next:
    • Commit 1/2: Noqcom,shikra-ctcu not found in qcom-next
    • Commit 2/2: Partial — Different version found as 5f9f6b52570d with significantly different stats (+111 insertions, +98 deletions difference)

Overall Assessment

⚠️ PARTIAL VALIDATION — Commit message structure is correct for both commits (FROMLIST prefix, Link tags, Signed-off-by present), but:

  1. Network restrictions prevent full validation of diff faithfulness and upstream acceptance status
  2. Commit 2/2 divergence from qcom-next version requires investigation:
    • PR has 209 more insertions and 98 more deletions than qcom-next 5f9f6b52570d
    • This could indicate a newer lore revision or unintended bundled changes

Action required: When network access is available:

  1. Fetch both lore patches using b4 am <message-id>
  2. Compare PR diffs against lore diffs using interdiff or filterdiff
  3. Verify upstream acceptance status by scanning lore threads for merge/NAK signals
  4. Investigate why commit 2/2 differs from qcom-next version — check if lore has multiple revisions (v1, v2, etc.)

@qlijarvis

Copy link
Copy Markdown

PR #824 — checker-log-analyzer

PR: #824
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/29320312734

Checker Result Summary
Checker Result Summary
checkpatch No style issues
dt-binding-check Schema validation passed
dtb-check Pre-existing iommus validation error exposed
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance Content mismatch with upstream link
tag-check Both commits have FROMLIST: prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #824 - Add coresight nodes for shikra
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/29320312734

Checker Result Summary
checkpatch No style issues
dt-binding-check Schema validation passed
dtb-check Pre-existing iommus validation error exposed
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance Content mismatch with upstream link
tag-check Both commits have FROMLIST: prefix

❌ dtb-check

Root cause: Pre-existing video-codec@5a00000 node in shikra.dtsi has an iommus property with insufficient cells for the qcom,shikra-iris binding.

Failure details:

shikra-cqm-evk.dtb: video-codec@5a00000 (qcom,shikra-iris): iommus: [[43, 1920, 32]] is too short
shikra-cqm-evk-imx577-camera.dtb: video-codec@5a00000 (qcom,shikra-iris): iommus: [[43, 1920, 32]] is too short
shikra-cqs-evk.dtb: video-codec@5a00000 (qcom,shikra-iris): iommus: [[43, 1920, 32]] is too short
shikra-cqs-evk-imx577-camera.dtb: video-codec@5a00000 (qcom,shikra-iris): iommus: [[43, 1920, 32]] is too short
shikra-iqs-evk.dtb: video-codec@5a00000 (qcom,shikra-iris): iommus: [[42, 1920, 32]] is too short
shikra-iqs-evk-imx577-camera.dtb: video-codec@5a00000 (qcom,shikra-iris): iommus: [[42, 1920, 32]] is too short

Analysis: This PR adds coresight nodes to shikra.dtsi but does not modify the video-codec@5a00000 node. The error is flagged as "new" by the checker because:

  • The checker subtracts base_dtbs_errors.log from head_dtbs_errors.log
  • This error was not present in the base build, likely because these specific shikra DTB variants were not built or validated at the base commit
  • The video-codec@5a00000 node is pre-existing in shikra.dtsi and has an iommus property that doesn't meet the cell count requirements of the qcom,shikra-iris binding

Fix: The iommus property in the video-codec@5a00000 node needs additional cells. Check the qcom,shikra-iris binding schema to determine the required cell count and update the iommus property accordingly in shikra.dtsi.

Reproduce locally:

make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/shikra-cqm-evk.dtb

❌ check-patch-compliance

Root cause: The second commit's content differs from the upstream patch referenced in the Link: tag.

Failure details:

Checking commit: FROMLIST: arm64: dts: qcom: shikra: Add coresight nodes
Change is different from the one mentioned in Link

Analysis: The commit references:

Link: https://lore.kernel.org/all/20260714-add-coresight-nodes-for-shikra-v1-2-b1cf85962455@oss.qualcomm.com/

The checker fetched the upstream patch using b4 am and found that the diff content doesn't match. This could be due to:

  1. Context line differences (false positive)
  2. Additional changes not in the upstream version
  3. Missing hunks from the upstream version
  4. The upstream patch was updated after the Link was added

Fix:

# Fetch the upstream patch
b4 am --single-message -C -l -3 https://lore.kernel.org/all/20260714-add-coresight-nodes-for-shikra-v1-2-b1cf85962455@oss.qualcomm.com/ -o /tmp/upstream

# Compare the actual changes (+ and - lines only)
git format-patch -1 bbb3559721cf --stdout > /tmp/pr-patch.txt
diff <(awk '/^diff/,/^--$/' /tmp/pr-patch.txt | grep -E '^[+-][^+-]') \
     <(awk '/^diff/,/^--$/' /tmp/upstream/*.mbx | grep -E '^[+-][^+-]')

If the differences are:

  • Context-only shifts: Document this as an acceptable adaptation
  • Legitimate adaptations: Add a note in the commit message explaining the changes
  • Missing hunks: Cherry-pick the missing changes
  • Extra hunks: Consider splitting into a separate commit or removing if not needed

Reproduce locally:

cd /path/to/kernel
bash ../kernel-checkers/check-patch-compliance.sh --kernel-src . \
  --base 48143db58c4c --head bbb3559721cf

Verdict

2 blockers to fix before merge:

  1. dtb-check (pre-existing): The video-codec@5a00000 iommus validation error is a pre-existing issue in shikra.dtsi that's now being exposed by this PR's DTB builds. While not introduced by this PR, it blocks CI. Options:

    • Fix the video-codec@5a00000 iommus property in this PR
    • Request maintainer approval to merge despite pre-existing tree issue
    • File a separate issue/PR to fix the video-codec node
  2. check-patch-compliance (content mismatch): The second commit's diff doesn't match the upstream lore link. Investigate and either:

    • Update the commit to match upstream exactly
    • Document the intentional differences in the commit message
    • Update the Link: tag if the upstream patch was revised

@jiegan0107

Jie Gan (jiegan0107) commented Jul 14, 2026

Copy link
Copy Markdown
Author
check-patch-compliance | ❌ | Content mismatch with upstream link -- | -- | --

The content of the lore link has issue. It shows the patch diff twice, but the content is correct in received message.

@qcomlnxci

Copy link
Copy Markdown

Test Matrix

Test Case hamoa-iot-evk lemans-evk monaco-evk qcs615-ride qcs6490-rb3gen2 qcs8300-ride qcs9100-ride-r3
BT_FW_KMD_Service ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
BT_ON_OFF ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
BT_SCAN ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
CPUFreq_Validation ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
CPU_affinity ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
DSP_AudioPD ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
Ethernet ◻️ ⚠️ skip ⚠️ skip ⚠️ skip ⚠️ skip ◻️ ⚠️ skip
Freq_Scaling ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
GIC ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
IPA ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
Interrupts ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
OpenCV ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
PCIe ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
Probe_Failure_Check ◻️ ❌ Fail ❌ Fail ❌ Fail ❌ Fail ◻️ ❌ Fail
RMNET ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
UFS_Validation ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
USBHost ◻️ ❌ Fail ❌ Fail ❌ Fail ❌ Fail ◻️ ❌ Fail
WiFi_Firmware_Driver ◻️ ✅ Pass ❌ Fail ✅ Pass ✅ Pass ◻️ ✅ Pass
WiFi_OnOff ◻️ ✅ Pass ❌ Fail ✅ Pass ✅ Pass ◻️ ✅ Pass
adsp_remoteproc ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
cdsp_remoteproc ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
gpdsp_remoteproc ◻️ ✅ Pass ✅ Pass ⚠️ skip ⚠️ skip ◻️ ✅ Pass
hotplug ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
irq ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
kaslr ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
pinctrl ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
qcom_hwrng ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
remoteproc ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
rngtest ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
shmbridge ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
smmu ◻️ ❌ Fail ✅ Pass ❌ Fail ✅ Pass ◻️ ❌ Fail
watchdog ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
wpss_remoteproc ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass

@qcomlnxci

Copy link
Copy Markdown

Test Matrix

Test Case hamoa-iot-evk lemans-evk monaco-evk qcs615-ride qcs6490-rb3gen2 qcs8300-ride qcs9100-ride-r3
BT_FW_KMD_Service ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass
BT_ON_OFF ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass
BT_SCAN ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass
CPUFreq_Validation ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass
CPU_affinity ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass
DSP_AudioPD ⚠️ skip ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass
Ethernet ⚠️ skip ⚠️ skip ⚠️ skip ◻️ ⚠️ skip ⚠️ skip ⚠️ skip
Freq_Scaling ✅ Pass ✅ Pass ✅ Pass ◻️ ❌ Fail ✅ Pass ✅ Pass
GIC ✅ Pass ✅ Pass ✅ Pass ◻️ ❌ Fail ✅ Pass ✅ Pass
IPA ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass
Interrupts ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass
OpenCV ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass
PCIe ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass
Probe_Failure_Check ❌ Fail ❌ Fail ❌ Fail ◻️ ❌ Fail ❌ Fail ❌ Fail
RMNET ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass
UFS_Validation ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass
USBHost ✅ Pass ❌ Fail ❌ Fail ◻️ ❌ Fail ❌ Fail ❌ Fail
WiFi_Firmware_Driver ❌ Fail ✅ Pass ❌ Fail ◻️ ✅ Pass ✅ Pass ✅ Pass
WiFi_OnOff ❌ Fail ✅ Pass ❌ Fail ◻️ ✅ Pass ✅ Pass ✅ Pass
adsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass
cdsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass
gpdsp_remoteproc ⚠️ skip ✅ Pass ✅ Pass ◻️ ⚠️ skip ✅ Pass ✅ Pass
hotplug ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass
irq ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass
kaslr ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass
pinctrl ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass
qcom_hwrng ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass
remoteproc ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass
rngtest ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass
shmbridge ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass
smmu ❌ Fail ❌ Fail ✅ Pass ◻️ ✅ Pass ✅ Pass ❌ Fail
watchdog ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass
wpss_remoteproc ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass

Jie Gan (jiegan0107) and others added 2 commits July 16, 2026 09:53
The CTCU device for shikra shares the same configurations as SA8775p.
Add a fallback to enable the CTCU for shikra to utilize the compatible
of the SA8775p.

Link: https://lore.kernel.org/all/20260714-add-coresight-nodes-for-shikra-v1-1-b1cf85962455@oss.qualcomm.com/
Signed-off-by: Jie Gan <jie.gan@oss.qualcomm.com>
Add DT nodes for the CoreSight debug and trace subsystem on Qualcomm
Shikra SoC.

Link: https://lore.kernel.org/all/20260715-add-coresight-nodes-for-shikra-v2-2-ebd485e39a51@oss.qualcomm.com/
Signed-off-by: Jie Gan <jie.gan@oss.qualcomm.com>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sgaud-quic

Copy link
Copy Markdown
Contributor

PR #824 — validate-patch

PR: #824

Verdict Issues Detailed Report
2 Full report

Final Summary

  1. Lore link present: Yes — both commits include lore.kernel.org links.
  2. Lore link matches PR commits: Partial — commit 1 links stale v1; commit 2 includes v2 content but has extra non-lore diff churn.
  3. Upstream patch status: In review — fetched mboxes show no applied/queued/merged, Reviewed-by/Acked-by, or NAK signal; v1 is superseded by v2.
  4. PR present in qcom-next/topics: Fail - 1/2 commit(s) are missing from both qcom-next and topics
Verdict: ❌ — click to expand

🔍 Patch Validation

PR: Add CoreSight nodes for Qualcomm Shikra SoC #824
Upstream commit: https://lore.kernel.org/all/20260714-add-coresight-nodes-for-shikra-v1-1-b1cf85962455@oss.qualcomm.com/ and https://lore.kernel.org/all/20260715-add-coresight-nodes-for-shikra-v2-2-ebd485e39a51@oss.qualcomm.com/
Verdict: ❌ FAIL

Commit Message

Check Status Note
Subject matches upstream Both subjects match the lore subjects with expected FROMLIST: prefix.
Body preserves rationale Rationale is preserved for both commits.
Fixes tag present/correct No Fixes tag expected for this feature series.
Authorship preserved FROMLIST: rule satisfied: lore author Signed-off-by: Jie Gan <jie.gan@oss.qualcomm.com> is present.
Backport note (if applicable) N/A Not a backport.

Diff

File Status Notes
Documentation/devicetree/bindings/arm/qcom,coresight-ctcu.yaml Same compatible addition; only target-tree context differs.
arch/arm64/boot/dts/qcom/shikra.dtsi CoreSight additions align with v2, but PR diff includes large remove/re-add blocks for existing nodes absent from lore.

Issues

  • Commit 1 links the v1 lore posting even though the local evidence contains a v2 series. The v2 cover says Changes in v2: remove MMIO for the ETM devices; update lore links to the current v2 revision where applicable.
  • Commit 2 is not a faithful diff representation of the v2 lore patch: lore v2 is 1295 insertions(+), while the PR commit is 1473 insertions(+), 178 deletions(-) and includes remove/re-add churn for existing sram, apps_smmu, wifi, interrupt-controller, mailbox, watchdog, and timer nodes.

Verdict

Do not merge as-is. Regenerate or split the DTS change so the PR patch is a faithful v2 lore import, and resolve the qcom-next/topics presence failure.

Final Summary

  1. Lore link present: Yes — both commits include lore.kernel.org links.
  2. Lore link matches PR commits: Partial — commit 1 links stale v1; commit 2 includes v2 content but has extra non-lore diff churn.
  3. Upstream patch status: In review — fetched mboxes show no applied/queued/merged, Reviewed-by/Acked-by, or NAK signal; v1 is superseded by v2.
  4. PR present in qcom-next/topics: Fail — integration report says 0/2 present, commit 1 missing, commit 2 partial only.

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: a5cf3debd8c3c660711ad586ad4bb84e9ca42635
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/2 [PATCH 1/2] FROMLIST: dt-bindings: arm: add CTCU device for shikra missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
2/2 [PATCH 2/2] FROMLIST: arm64: dts: qcom: shikra: Add coresight nodes partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial

Final Status

overall_status: FAIL
present_commits: 0/2
partial_commits: 1/2
missing_commits: 1/2
topics_checked_for_commits: 2/2
final_summary: PR present in qcom-next/topics: Fail - 1/2 commit(s) are missing from both qcom-next and topics

@sgaud-quic

Copy link
Copy Markdown
Contributor

PR #824 — checker-log-analyzer

PR: #824
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/29465335551

Checker Result Summary
Checker Result Summary
checkpatch Commit 2 has From: / Signed-off-by: email mismatch.
dt-binding-check Modified CTCU binding rejects existing qcom,hamoa-ctcu users during dtbs_check.
dtb-check New Shikra DTB schema failures: video-codec@5a00000 iommus list is too short.
sparse-check ⏭️ Skipped: no relevant C/H changes.
check-uapi-headers ⏭️ Skipped: no UAPI-relevant changes.
check-patch-compliance Commit 2 differs from linked lore patch and has author mismatch.
tag-check Target is not qcom-next/qcom-next-staging; both commits have valid FROMLIST: prefix.
qcom-next-check Both commits use FROMLIST:.

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: FROMLIST CTCU binding + Shikra CoreSight nodes (#824)
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/29465335551
Target branch: qcom-6.18.y

Checker Result Summary
checkpatch Commit 2 has From: / Signed-off-by: email mismatch.
dt-binding-check Modified CTCU binding rejects existing qcom,hamoa-ctcu users during dtbs_check.
dtb-check New Shikra DTB schema failures: video-codec@5a00000 iommus list is too short.
sparse-check ⏭️ Skipped: no relevant C/H changes.
check-uapi-headers ⏭️ Skipped: no UAPI-relevant changes.
check-patch-compliance Commit 2 differs from linked lore patch and has author mismatch.
tag-check Target is not qcom-next/qcom-next-staging; both commits have valid FROMLIST: prefix.
qcom-next-check Both commits use FROMLIST:.

❌ checkpatch

Root cause: Commit 44dda89cbc15 author email does not match its Signed-off-by.

Failure details:

Commit 44dda89cbc15 ("FROMLIST: arm64: dts: qcom: shikra: Add coresight nodes")
WARNING: From:/Signed-off-by: email address mismatch:
'From: Jie Gan <jiegan@qti.qualcomm.com>' !=
'Signed-off-by: Jie Gan <jie.gan@oss.qualcomm.com>'

Fix: Amend commit 2 so the author and sign-off use the same intended identity, preferably:

Jie Gan <jie.gan@oss.qualcomm.com>

Reproduce locally:

./scripts/checkpatch.pl --strict --summary-file --ignore FILE_PATH_CHANGES --git a19888edbd0a4a46d624c9abe66d5f5ef4042abb..44dda89cbc158dc69b38869233b824736caf5e14

❌ dt-binding-check

Root cause: The changed qcom,coresight-ctcu.yaml adds qcom,shikra-ctcu but still does not allow existing qcom,hamoa-ctcu, so dtbs_check fails for Hamoa/Purwa DTBs.

Failure details:

hamoa-iot-evk.dtb: ctcu@10001000 (qcom,hamoa-ctcu): compatible: 'oneOf' conditional failed
['qcom,hamoa-ctcu', 'qcom,sa8775p-ctcu'] is too long
'qcom,hamoa-ctcu' is not one of ['qcom,qcs8300-ctcu', 'qcom,shikra-ctcu']
'qcom,hamoa-ctcu' is not one of ['qcom,sa8775p-ctcu']
from schema $id: http://devicetree.org/schemas/arm/qcom,coresight-ctcu.yaml#

Fix: Update Documentation/devicetree/bindings/arm/qcom,coresight-ctcu.yaml to also model the existing Hamoa fallback, for example by adding qcom,hamoa-ctcu to the first enum if it is compatible with qcom,sa8775p-ctcu.

Reproduce locally:

make -j$(nproc) O=out dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/qcom,coresight-ctcu.yaml

❌ dtb-check

Root cause: The Shikra DTB validation found new qcom,shikra-iris video-codec iommus entries with too few items after base/head subtraction.

Failure details:

Log Summary: Test failed
shikra-cqm-evk.dtb: video-codec@5a00000 (qcom,shikra-iris): iommus: [[47, 1920, 32]] is too short
shikra-cqm-evk-imx577-camera.dtb: video-codec@5a00000 (qcom,shikra-iris): iommus: [[47, 1920, 32]] is too short
shikra-cqs-evk.dtb: video-codec@5a00000 (qcom,shikra-iris): iommus: [[47, 1920, 32]] is too short
shikra-iqs-evk.dtb: video-codec@5a00000 (qcom,shikra-iris): iommus: [[46, 1920, 32]] is too short

Fix: Fix the Shikra video-codec@5a00000 node to satisfy the qcom,shikra-iris binding, likely by adding the missing iommus entries or correcting the binding if a single IOMMU stream is valid for this hardware.

Reproduce locally:

make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/shikra-cqm-evk.dtb

❌ check-patch-compliance

Root cause: Commit 2 does not match the linked lore patch and its commit author differs from the original lore author.

Failure details:

Checking commit: FROMLIST: arm64: dts: qcom: shikra: Add coresight nodes
Change is different from the one mentioned in Link
Author mismatch:
  Original author: Jie Gan <jie.gan@oss.qualcomm.com>
  Commit author : Jie Gan <jiegan@qti.qualcomm.com>

Fix: Amend commit 2 author to Jie Gan <jie.gan@oss.qualcomm.com>, then either make the patch content match the linked lore patch or repost the adapted version and update the Link: trailer.

Reproduce locally:

b4 am --single-message -C -l -3 https://lore.kernel.org/all/20260715-add-coresight-nodes-for-shikra-v2-2-ebd485e39a51@oss.qualcomm.com/ -o /tmp/out

Verdict

Not ready to merge. Fix the commit 2 author/sign-off mismatch, resolve the lore content mismatch, update the CTCU binding for existing Hamoa users, and fix the Shikra Iris iommus DTB schema failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants