Fix hyperref label mismatch for tech/def cross-references in LaTeX#565
Open
wilbowma wants to merge 1 commit into
Open
Fix hyperref label mismatch for tech/def cross-references in LaTeX#565wilbowma wants to merge 1 commit into
wilbowma wants to merge 1 commit into
Conversation
When rendering `@tech` links with `#:tag-prefixes`, the resolved destination
tag (e.g. `(tech "chp1:" "book:" "widget")`) differs from the raw
link-element tag (e.g. `(tech ("book:" "chp1:" "widget"))`), causing
`\hyperref` to reference a label that does not exist.
The section/part rendering path appears to handle this by using
`(vector-ref dest 1)` from the resolved destination rather than
`(link-element-tag e)`. Adapt the same pattern for tech/def refs.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Resyntax analyzed 2 files in this pull request and found no issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When rendering
@techlinks with#:tag-prefixes, the resolved destination tag (e.g.(tech "chp1:" "book:" "widget")) differs from the raw link-element tag (e.g.(tech ("book:" "chp1:" "widget"))), causing\hyperrefto reference a label that does not exist.The section/part rendering path appears to handle this by using
(vector-ref dest 1)from the resolved destination rather than(link-element-tag e). Adapt the same pattern for tech/def refs.